fix(Avatar): fall back to initials when imageUrl is an empty string#3168
Merged
fix(Avatar): fall back to initials when imageUrl is an empty string#3168
Conversation
An empty string passed `typeof imageUrl === 'string'`, so the component rendered `<img src="">`, which makes the browser attempt to load the current document URL as an image. Add a truthy check so empty strings fall through to the initials/icon fallback path.
|
Size Change: +10 B (0%) Total Size: 673 kB 📦 View Changed
ℹ️ View Unchanged
|
arnautov-anton
approved these changes
May 5, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3168 +/- ##
==========================================
- Coverage 83.55% 83.50% -0.05%
==========================================
Files 434 434
Lines 12949 12949
Branches 4170 4170
==========================================
- Hits 10819 10813 -6
- Misses 2130 2136 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Prevent the
Avatarcomponent from rendering an<img>element with an emptysrcwhenimageUrlis an empty string. An emptysrcmakes the browser attempt to load the current document URL as an image, which both wastes a request and triggers an unintendedonError(which would then flip the avatar into the error fallback for the wrong reason).🛠 Implementation details
showImagepreviously only checked thatimageUrlwas a string. An empty string passestypeof imageUrl === 'string', so the<img>was rendered withsrc="". Added a truthy check so an empty string now falls through to the initials/icon fallback path. Added a regression test for the empty-string case.🎨 UI Changes
No visual changes for valid image URLs. When
imageUrl="", the avatar now renders the username initials (orIconUserfallback) instead of a broken<img>.