[CI] Revert -Osize flag implementation by testableapple · Pull Request #3899 · GetStream/stream-chat-swift

testableapple · 2025-12-18T17:46:53Z

🎯 Goal

Resolve:

.unsafeFlags are not allowed for dependencies specified with a version. The workaround is to specify the version with a commit hash.

Summary by CodeRabbit

Chores
- Updated CI workflows to explicitly specify Xcode version 16.4
- Modified release build configurations to use default optimization settings

_{✏️ Tip: You can customize this high-level summary in your review settings.}

coderabbitai · 2025-12-18T17:47:08Z

Walkthrough

Standardizes Xcode version to 16.4 across three GitHub Actions workflows and removes explicit Swift size optimization settings (SWIFT_OPTIMIZATION_LEVEL = -Osize) from Package.swift, podspecs, and the Xcode project configuration, reverting to default compiler optimization behavior for release builds.

Changes

Cohort / File(s)	Summary
GitHub Actions Workflows – Xcode Version `.github/workflows/release-publish.yml`, `.github/workflows/sdk-performance-metrics.yml`, `.github/workflows/sdk-size-metrics.yml`	Added top-level environment variable `XCODE_VERSION` set to `"16.4"` in each workflow file; no changes to triggers or job logic.
Build Configuration – Size Optimization Removal `Package.swift`, `StreamChat.podspec`, `StreamChat-XCFramework.podspec`	Removed explicit Swift optimization level setting (`SWIFT_OPTIMIZATION_LEVEL = -Osize`) from build configurations; builds now default to compiler's standard optimization level.
Xcode Project Configuration `StreamChat.xcodeproj/project.pbxproj`	Removed `SWIFT_OPTIMIZATION_LEVEL = "-Osize"` setting from Release build configurations across multiple targets (`DemoAppPush`, `StreamChatUI`, `StreamChat`, and others); falls back to default compiler optimization behavior.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Areas of attention: The StreamChat.xcodeproj/project.pbxproj file is a complex project configuration file affecting multiple targets; verify that the removal of optimization settings is applied consistently across all intended build configurations and that no unintended deletions occurred in the binary-format project file.

Possibly related PRs

[CI] Support Xcode 26 #3825: Also modifies the same build configuration settings (SWIFT_OPTIMIZATION_LEVEL / -Osize) and updates XCODE_VERSION in CI workflows, with opposite direction changes.
[CI] Bump Xcode version and resolve snapshot tests #3786: Updates Xcode version settings in GitHub Actions workflows to reference Xcode 16.4.
[CI] Implement detailed size metrics #3839: Modifies .github/workflows/sdk-size-metrics.yml with changes to workflow environment and step configuration.

Suggested reviewers

laevandus
martinmitrevski

Poem

🐰 Size limits swept away, Xcode 16.4 holds sway!
No more cramped builds in the night,
Default compilers set things right.
A Swift tale of optimization's flight! 🚀

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: reverting the -Osize flag optimization across multiple build configuration files and workflows.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch ci/size-flag

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 2592f16 and d7a4065.

📒 Files selected for processing (7)

.github/workflows/release-publish.yml (1 hunks)
.github/workflows/sdk-performance-metrics.yml (1 hunks)
.github/workflows/sdk-size-metrics.yml (1 hunks)
Package.swift (1 hunks)
StreamChat-XCFramework.podspec (0 hunks)
StreamChat.podspec (0 hunks)
StreamChat.xcodeproj/project.pbxproj (0 hunks)

💤 Files with no reviewable changes (3)

StreamChat.xcodeproj/project.pbxproj
StreamChat.podspec
StreamChat-XCFramework.podspec

🧰 Additional context used

📓 Path-based instructions (1)

**/*.swift

📄 CodeRabbit inference engine (AGENTS.md)

**/*.swift: Write Swift code compatible with iOS deployment targets specified in Package.swift and podspec files; do not lower deployment targets without approval
Use SwiftLint with strict mode and respect .swiftlint.yml rules; justify and scope any exceptions rather than suppressing rules broadly
Run SwiftFormat for code formatting and respect repository-specific style conventions
Never commit API keys or customer data; use obvious placeholders (e.g., YOUR_STREAM_KEY) in example code
Follow the project's zero-warnings policy: fix new warnings and avoid introducing any

Files:

Package.swift

🧠 Learnings (9)

📓 Common learnings

Learnt from: CR
Repo: GetStream/stream-chat-swift PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-11-25T12:17:18.459Z
Learning: Applies to **/*.swift : Write Swift code compatible with iOS deployment targets specified in Package.swift and podspec files; do not lower deployment targets without approval

Learnt from: CR
Repo: GetStream/stream-chat-swift PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-11-25T12:17:18.459Z
Learning: Applies to **/*.swift : Run SwiftFormat for code formatting and respect repository-specific style conventions