Closed
Conversation
Signed-off-by: John E <jeis4wpi@outlook.com>
📝 WalkthroughWalkthroughThis PR corrects spelling errors throughout the codebase, including "succesfully" → "successfully", "beeing" → "being", "tread" → "thread", and "Editted" → "Edited", alongside minor whitespace adjustments across test files and one debug log statement. No functional logic is modified. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
Tests/StreamChatTests/StateLayer/Chat_Tests.swift (1)
531-531: Optional: clean remaining typos in touched test names/comments for consistency.A few typo variants remain in modified lines (e.g.,
Succeess,Succeds,Consequtive,Unpining,inital).Proposed rename/comment cleanup
- func test_downloadAttachment_whenMessageUpdaterSucceeds_thenSucceess() async throws { + func test_downloadAttachment_whenMessageUpdaterSucceeds_thenSuccess() async throws { - func test_deleteLocalAttachmentDownload_whenMessageUpdaterSucceeds_thenSucceess() async throws { + func test_deleteLocalAttachmentDownload_whenMessageUpdaterSucceeds_thenSuccess() async throws { - func test_sendMessageAction_whenAPIRequestSucceds_thenSendMessageActionSucceeds() async throws { + func test_sendMessageAction_whenAPIRequestSucceeds_thenSendMessageActionSucceeds() async throws { - func test_updateMessage_whenTwoConsequtiveTextUpdates_thenWebSocketEventDoesNotResetTextToTheFirstEdit() async throws { + func test_updateMessage_whenTwoConsecutiveTextUpdates_thenWebSocketEventDoesNotResetTextToTheFirstEdit() async throws { - // Accessing the state triggers loading the inital states + // Accessing the state triggers loading the initial states - func test_unpin_whenChannelUpdaterSucceeds_thenUnpiningSucceeds() async throws { + func test_unpin_whenChannelUpdaterSucceeds_thenUnpinningSucceeds() async throws {Also applies to: 552-552, 673-673, 815-815, 880-880, 893-893, 1768-1768
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@Tests/StreamChatTests/StateLayer/Chat_Tests.swift` at line 531, Fix remaining typos in test names and comments in Chat_Tests.swift: rename test_downloadAttachment_whenMessageUpdaterSucceeds_thenSucceess to test_downloadAttachment_whenMessageUpdaterSucceeds_thenSuccess and correct other occurrences of misspellings (e.g., change "Succeds" to "Succeeds", "Consequtive" to "Consecutive", "Unpining" to "Unpinning", "inital" to "initial") in the touched test function names and inline comments (search for the variants listed and update the corresponding test functions and comment strings so names and descriptions are consistently spelled).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@Tests/StreamChatTests/StateLayer/Chat_Tests.swift`:
- Line 531: Fix remaining typos in test names and comments in Chat_Tests.swift:
rename test_downloadAttachment_whenMessageUpdaterSucceeds_thenSucceess to
test_downloadAttachment_whenMessageUpdaterSucceeds_thenSuccess and correct other
occurrences of misspellings (e.g., change "Succeds" to "Succeeds", "Consequtive"
to "Consecutive", "Unpining" to "Unpinning", "inital" to "initial") in the
touched test function names and inline comments (search for the variants listed
and update the corresponding test functions and comment strings so names and
descriptions are consistently spelled).
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 4054e954-3f61-4149-a2f6-077f437504c7
📒 Files selected for processing (7)
Sources/StreamChat/Database/DatabaseContainer.swiftStreamChatUITestsAppUITests/Tests/Attachments_Tests.swiftStreamChatUITestsAppUITests/Tests/Message Delivery Status/MessageDeliveryStatus+ChannelList_Tests.swiftStreamChatUITestsAppUITests/Tests/Message Delivery Status/MessageDeliveryStatus_Tests.swiftStreamChatUITestsAppUITests/Tests/QuotedReply_Tests.swiftTests/StreamChatTests/Database/DTOs/MemberModelDTO_Tests.swiftTests/StreamChatTests/StateLayer/Chat_Tests.swift
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Issue Links
Provide all Linear and/or Github issues related to this PR, if applicable.
🎯 Goal
Describe why we are making this change.
📝 Summary
Propose fix some typos
Provide bullet points with the most important changes in the codebase.
🛠 Implementation
Provide a detailed description of the implementation and explain your decisions if you find them relevant.
🎨 Showcase
Add relevant screenshots and/or videos/gifs to easily see what this PR changes, if applicable.
🧪 Manual Testing Notes
Explain how this change can be tested manually, if applicable.
☑️ Contributor Checklist
docs-contentrepoSummary by CodeRabbit