Skip to content

Commit 1196def

Browse files
authored
chore: upgrade puppeteer, only download chrome in browser test action, turn on yarn cache (#646)
* chore: turn on yarn cache * chore: attempted fix, don't install puppeteer when not necessary * Update puppeteer to latest version * Run unit tests on node 16 too * Remove dummy unit test * Update checkout and setup-node to use node 24 * Save package manager in package.json * Skip downloading chrome to avoid postinstall script getting stuck (known issue in Yarn@1), browser test sets up browser in a separate step
1 parent f13992f commit 1196def

12 files changed

Lines changed: 295 additions & 36 deletions

File tree

.github/actions/setup-node/action.yml

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -5,23 +5,22 @@ inputs:
55
node-version:
66
required: false
77
default: '24'
8+
skip-puppeteer:
9+
required: false
10+
default: 'true'
811

912
runs:
1013
using: 'composite'
1114
steps:
1215
- name: Setup Node
13-
uses: actions/setup-node@v4
16+
uses: actions/setup-node@v5
1417
with:
1518
node-version: ${{ inputs.node-version }}
1619
registry-url: 'https://registry.npmjs.org'
17-
18-
- name: Cache Dependencies
19-
uses: actions/cache@v4
20-
with:
21-
path: ./node_modules
22-
key: ${{ runner.os }}-${{ inputs.node-version }}-modules-${{ hashFiles('**/yarn.lock') }}
23-
restore-keys: ${{ runner.os }}-${{ inputs.node-version }}-modules-
20+
cache: 'yarn'
2421

2522
- name: Install Dependencies & Build
2623
run: yarn install --frozen-lockfile --ignore-engines
2724
shell: bash
25+
env:
26+
PUPPETEER_SKIP_DOWNLOAD: ${{ inputs.skip-puppeteer }}

.github/workflows/browser.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,11 @@ jobs:
1010
browser:
1111
runs-on: ubuntu-latest
1212
steps:
13-
- uses: actions/checkout@v4
13+
- uses: actions/checkout@v5
1414
- uses: ./.github/actions/setup-node
15+
- name: Install Chrome
16+
run: npx puppeteer browsers install chrome
17+
shell: bash
1518
- name: Test
1619
env:
1720
STREAM_APP_ID: ${{ secrets.STREAM_APP_ID }}

.github/workflows/cloud.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ jobs:
1010
qa:
1111
runs-on: ubuntu-latest
1212
steps:
13-
- uses: actions/checkout@v4
13+
- uses: actions/checkout@v5
1414
- uses: ./.github/actions/setup-node
1515
- name: Test
1616
env:

.github/workflows/initiate_release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ jobs:
1212
name: 🚀 Create release PR
1313
runs-on: ubuntu-latest
1414
steps:
15-
- uses: actions/checkout@v4
15+
- uses: actions/checkout@v5
1616
with:
1717
fetch-depth: 0 # gives the changelog generator access to all previous commits
1818

.github/workflows/integration.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ jobs:
1010
integration:
1111
runs-on: ubuntu-latest
1212
steps:
13-
- uses: actions/checkout@v4
13+
- uses: actions/checkout@v5
1414
- uses: ./.github/actions/setup-node
1515
- name: Test
1616
env:

.github/workflows/lint.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ jobs:
1010
lint:
1111
runs-on: ubuntu-latest
1212
steps:
13-
- uses: actions/checkout@v4
13+
- uses: actions/checkout@v5
1414
- uses: ./.github/actions/setup-node
1515
- name: Lint
1616
run: yarn run lint

.github/workflows/release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
if: github.event.pull_request.merged && startsWith(github.head_ref, 'release-')
1717
runs-on: ubuntu-latest
1818
steps:
19-
- uses: actions/checkout@v4
19+
- uses: actions/checkout@v5
2020
with:
2121
fetch-depth: 0
2222

.github/workflows/size.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,10 @@ jobs:
1212
build:
1313
runs-on: ubuntu-latest
1414
steps:
15-
- uses: actions/checkout@v4
15+
- uses: actions/checkout@v5
1616
- uses: preactjs/compressed-size-action@v2
17+
env:
18+
PUPPETEER_SKIP_DOWNLOAD: 'true'
1719
with:
1820
repo-token: '${{ secrets.GITHUB_TOKEN }}'
1921
build-script: 'dist'

.github/workflows/type.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ jobs:
1010
types:
1111
runs-on: ubuntu-latest
1212
steps:
13-
- uses: actions/checkout@v4
13+
- uses: actions/checkout@v5
1414
- uses: ./.github/actions/setup-node
1515
- name: Type check
1616
run: yarn run types

.github/workflows/unit.yml

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -7,20 +7,13 @@ on:
77
pull_request:
88

99
jobs:
10-
# TODO: remove once branch protection is updated to drop unit (16)
11-
unit-legacy:
12-
name: 'unit (16)'
13-
runs-on: ubuntu-latest
14-
steps:
15-
- run: echo "Deprecated — Node 16 is EOL. This job exists only to satisfy branch protection."
16-
1710
unit:
1811
runs-on: ubuntu-latest
1912
strategy:
2013
matrix:
21-
node: [18, 20, 22, 24]
14+
node: [16, 18, 20, 22, 24]
2215
steps:
23-
- uses: actions/checkout@v4
16+
- uses: actions/checkout@v5
2417
- uses: ./.github/actions/setup-node
2518
with:
2619
node-version: ${{ matrix.node }}

0 commit comments

Comments
 (0)