-
Notifications
You must be signed in to change notification settings - Fork 14
Forward custom coordinator events through ConnectionManager #237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+76
−0
Merged
Changes from 4 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
fd4cc9f
feat: enable chat events on coordinator WebSocket
aliev c9a1471
revert: remove watch_channels and chat products for now
aliev aa1be05
docs: add docstring to coordinator_ws with send/receive examples
aliev 810998f
docs: shrink coordinator_ws docstring, move examples to commit
aliev 2b3ba0b
feat: add return type and connection check to coordinator_ws
aliev c68730c
test: add integration test for custom event round-trip via coordinato…
aliev f3f36d1
fix: log cleanup failures in test fixture instead of silently swallowing
aliev b151b75
test: use two participants in custom event test
aliev 00b84f7
refactor: re-emit coordinator events through ConnectionManager
aliev bf5f8ac
refactor: forward only custom events from coordinator WS
aliev b836ad4
refactor: drop coordinator_ws property from ConnectionManager
aliev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.