Skip to content

Commit b53d3bf

Browse files
fix(react-dogfood): do not request video ring on audio_call dialer (#2325)
### 💡 Overview The dialer page (`/ring?type=audio_call`) hardcodes `video: true` in its `call.getOrCreate({ ring: true, ... })` request regardless of the call type from the URL. The backend rejects ring requests with `video: true` on call types that have video disabled: ``` GetOrCreateCall failed with error: "Video is not enabled for this call" (code 4) ``` This breaks the audio ring flow on getstream.io/video/demos/ring (demo app `mmhfdzb5evj2`) — and with it every incoming-call E2E test in `stream-video-android`, including its develop nightly (red since ~Jul 2–6). Reproduction against the API: ``` POST /video/call/audio_call/x {"ring":true,"video":true} → 400 code 4 "Video is not enabled for this call" POST /video/call/audio_call/x {"ring":true,"video":false} → 200 ``` ### 📝 Implementation notes One line in `DialerPage.tsx`: derive the `video` flag from the call type instead of hardcoding it — `video: callType !== 'audio_call'`. Non-ring `getOrCreate` calls are unaffected (the backend only validates the flag on ring requests). Evidence trail (buddy browser recording showing the error toast, timeline, API probes): stream-video-android run `28856205639` artifacts. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Improved call setup so audio-only calls no longer attempt to enable video, preventing call initiation errors in supported cases. * Video is now enabled only for call types that support it, making dialing more reliable overall. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
1 parent acde928 commit b53d3bf

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

sample-apps/react/react-dogfood/components/Ringing/DialerPage.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,10 @@ export const DialerPage = ({
145145
setRingingCall(call);
146146
await call.getOrCreate({
147147
ring: true,
148-
video: true,
148+
// the backend rejects ring requests with `video: true` on call types
149+
// that have video disabled (e.g. `audio_call`):
150+
// "Video is not enabled for this call"
151+
video: callType !== 'audio_call',
149152
data: {
150153
members,
151154
settings_override: {

0 commit comments

Comments
 (0)