fix(react-dogfood): do not request video ring on audio_call dialer#2325
Conversation
The dialer hardcoded video: true in getOrCreate regardless of the call type from the URL. The backend rejects ring requests with video: true on call types that have video disabled: GetOrCreateCall code 4 "Video is not enabled for this call". This broke the audio ring flow on getstream.io/video/demos/ring (demo app mmhfdzb5evj2) and with it every incoming-call E2E test in stream-video-android, including its develop nightly.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe ChangesRing Video Flag Fix
Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Bundle sizeBuilt package output. Sizes in KB; delta vs No significant package size increase vs |
💡 Overview
The dialer page (
/ring?type=audio_call) hardcodesvideo: truein itscall.getOrCreate({ ring: true, ... })request regardless of the call type from the URL. The backend rejects ring requests withvideo: trueon call types that have video disabled:This breaks the audio ring flow on getstream.io/video/demos/ring (demo app
mmhfdzb5evj2) — and with it every incoming-call E2E test instream-video-android, including its develop nightly (red since ~Jul 2–6).Reproduction against the API:
📝 Implementation notes
One line in
DialerPage.tsx: derive thevideoflag from the call type instead of hardcoding it —video: callType !== 'audio_call'. Non-ringgetOrCreatecalls are unaffected (the backend only validates the flag on ring requests).Evidence trail (buddy browser recording showing the error toast, timeline, API probes): stream-video-android run
28856205639artifacts.Summary by CodeRabbit