chore: updated CXProvider init and config flow#2326
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThis PR updates iOS CallingxImpl provider configuration timing and adds a cached, serialized Settings store. It initializes callKeepCallController earlier, reapplies CXProvider configuration in setup/start flows, and reads handleType from stored settings. ChangesiOS Calling Provider Configuration and Settings Caching
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Bundle sizeBuilt package output. Sizes in KB; delta vs No significant package size increase vs |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/react-native-callingx/ios/CallingxImpl.swift`:
- Line 600: The outgoing call setup in CallingxImpl.startCall is mismatched with
the refreshed provider configuration because the CXStartCallAction handle type
is still hardcoded to generic. Update startCall to derive the outgoing handle
type from Settings.getProviderConfiguration() (or keep the provider
configuration pinned to generic) so the handle passed to CXStartCallAction stays
aligned with the configured handleType.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: cb099a7f-341f-4c9f-86d9-023f35932957
📒 Files selected for processing (2)
packages/react-native-callingx/ios/CallingxImpl.swiftpackages/react-native-callingx/ios/Settings.swift
💡 Overview
Avoided CXProvider redundant recreation.
Updated CXProvider configuration setup.
🎫 Ticket: https://linear.app/stream/issue/RN-414/cxprovider-instantiation-and-configuration-updates
Summary by CodeRabbit
Summary by CodeRabbit