Skip to content

[WebRTC]Upgrade to 145.8.0#1148

Merged
ipavlidakis merged 2 commits into
developfrom
iliaspavlidakis/webrtc-upgrade-145.8.0
May 25, 2026
Merged

[WebRTC]Upgrade to 145.8.0#1148
ipavlidakis merged 2 commits into
developfrom
iliaspavlidakis/webrtc-upgrade-145.8.0

Conversation

@ipavlidakis
Copy link
Copy Markdown
Contributor

@ipavlidakis ipavlidakis commented May 25, 2026

🔗 Issue Links

Resolves https://linear.app/stream/issue/IOS-1725/bugaudio-issue

🎯 Goal

Fix an AudioEngine/WebRTC regression where joining a call muted can break both sending and receiving audio.

The issue happens when muted speech detection enables recording-always-prepared mode before WebRTC registers its audio transport. In that order, WebRTC rejects the transport registration with Failed to set audio transport since media was active, then repeatedly logs Invalid audio transport.

📝 Summary

  • Updates the WebRTC dependency to include the AudioEngine transport registration fix.
  • Covers the regression with an iOS WebRTC test that reproduces the real join-muted flow.
  • Prevents muted-speech detection / prepared recording from leaving WebRTC without a valid audio transport.

🛠 Implementation

The fix is in the WebRTC fork. When AudioEngineDevice::RegisterAudioCallback needs to temporarily stop an already active audio buffer, it now also clears persistent recording state before registering the audio transport.

This allows AudioDeviceBuffer::RegisterAudioCallback to succeed, after which the previous AudioEngine state is restored.

The iOS SDK pulls in the fixed WebRTC artifact/version.

🎨 Showcase

N/A

Before After
Joining muted could produce Failed to set audio transport since media was active and repeated Invalid audio transport; audio send/receive failed. Joining muted no longer drops WebRTC audio transport; audio send/receive works.

🧪 Manual Testing Notes

Before the fix:

  1. Join a call directly from the app UI with microphone muted.
  2. Confirm muted speech detection / prepared recording is enabled.
  3. Observe WebRTC logs:
    • RegisterAudioCallback while active. Restarting audio buffer.
    • Failed to set audio transport since media was active
    • repeated Invalid audio transport
  4. Confirm audio send and receive do not work reliably.

After the fix:

  1. Join a call directly from the app UI with microphone muted.
  2. Confirm the call connects and audio transport registration succeeds.
  3. Verify the logs no longer contain Failed to set audio transport since media was active or repeated Invalid audio transport.
  4. Unmute and confirm local audio is sent.
  5. Confirm remote audio is received.

Regression comparison:

  • Also verify the CallKit ringing/answer flow still works.
  • Specifically test answering a CallKit call while muted and unmuting after join.

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero ⚠️ policy (required)
  • This change should receive manual QA
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (tutorial, CMS)

Summary by CodeRabbit

  • Bug Fixes

    • Fixed an audio initialization failure.
  • Chores

    • Updated stream-video-swift-webrtc dependency to version 145.8.0 across package managers.

Review Change Stack

@ipavlidakis ipavlidakis self-assigned this May 25, 2026
@ipavlidakis ipavlidakis requested a review from a team as a code owner May 25, 2026 18:47
@ipavlidakis ipavlidakis added the bug Something isn't working label May 25, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 25, 2026

📝 Walkthrough

Walkthrough

This PR updates the stream-video-swift-webrtc dependency from version 145.6.0 to 145.8.0 across all build configuration files (SwiftPM, CocoaPods, and Xcode project), and documents a fix for an AVAudioEngine initialization failure in the changelog.

Changes

WebRTC Dependency Update to 145.8.0

Layer / File(s) Summary
Dependency version bump and changelog
CHANGELOG.md, Package.swift, StreamVideo.podspec, StreamVideo-XCFramework.podspec, StreamVideo.xcodeproj/project.pbxproj
WebRTC dependency updated to 145.8.0 in SwiftPM, CocoaPods podspec prepare commands, and Xcode project configuration. Changelog entry documents the audio initialization fix addressed by this release.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • martinmitrevski

Poem

🐰 A hop, a bump, a version spree,
From 145-point-six to 145-point-eight we see,
Audio engines now initialize with grace,
Across all configs, synced in place,
Documentation keeps the changelog bright!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title '[WebRTC]Upgrade to 145.8.0' directly and accurately summarizes the main change: upgrading the WebRTC dependency from 145.6.0 to 145.8.0 across multiple configuration files. It is concise, clear, and specific.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch iliaspavlidakis/webrtc-upgrade-145.8.0

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@CHANGELOG.md`:
- Line 7: The "Fixed" heading under the "# Upcoming" section is using a triple-#
level ("### 🐞 Fixed") which jumps heading levels and triggers MD001; change the
"### 🐞 Fixed" line to a second-level heading "## 🐞 Fixed" so it directly
follows "# Upcoming" correctly and preserves markdown heading hierarchy; locate
the lines containing the "# Upcoming" heading and the "### 🐞 Fixed" heading to
make this adjustment.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ce6e6b3b-8140-4e8e-8316-1c337b2c14ab

📥 Commits

Reviewing files that changed from the base of the PR and between ef5c6eb and 74ba1f4.

⛔ Files ignored due to path filters (1)
  • Sources/StreamVideo/Generated/SystemEnvironment+Version.swift is excluded by !**/generated/**
📒 Files selected for processing (5)
  • CHANGELOG.md
  • Package.swift
  • StreamVideo-XCFramework.podspec
  • StreamVideo.podspec
  • StreamVideo.xcodeproj/project.pbxproj

Comment thread CHANGELOG.md
# Upcoming

### 🔄 Changed
### 🐞 Fixed
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Fix heading level increment in the Upcoming section.

Line [7] jumps from # Upcoming to ###, which triggers MD001 and can break markdown structure expectations in tooling.

Proposed fix
-### 🐞 Fixed
+## 🐞 Fixed
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
### 🐞 Fixed
## 🐞 Fixed
🧰 Tools
🪛 markdownlint-cli2 (0.22.1)

[warning] 7-7: Heading levels should only increment by one level at a time
Expected: h2; Actual: h3

(MD001, heading-increment)

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@CHANGELOG.md` at line 7, The "Fixed" heading under the "# Upcoming" section
is using a triple-# level ("### 🐞 Fixed") which jumps heading levels and
triggers MD001; change the "### 🐞 Fixed" line to a second-level heading "## 🐞
Fixed" so it directly follows "# Upcoming" correctly and preserves markdown
heading hierarchy; locate the lines containing the "# Upcoming" heading and the
"### 🐞 Fixed" heading to make this adjustment.

@ipavlidakis ipavlidakis changed the title [WebRTC]Upgrade to 146.8.0 [WebRTC]Upgrade to 145.8.0 May 25, 2026
@Stream-SDK-Bot
Copy link
Copy Markdown
Collaborator

SDK Size

title develop branch diff status
StreamVideo 10.31 MB 10.31 MB 0 KB 🟢
StreamVideoSwiftUI 2.47 MB 2.47 MB 0 KB 🟢
StreamVideoUIKit 2.6 MB 2.6 MB 0 KB 🟢
StreamWebRTC 11.87 MB 11.87 MB 0 KB 🟢

@github-actions
Copy link
Copy Markdown

Public Interface

🚀 No changes affecting the public interface.

@sonarqubecloud
Copy link
Copy Markdown

@ipavlidakis ipavlidakis merged commit cac6f5c into develop May 25, 2026
15 checks passed
@ipavlidakis ipavlidakis deleted the iliaspavlidakis/webrtc-upgrade-145.8.0 branch May 25, 2026 20:07
This was referenced May 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants