Feature/cms 13 upgrade#52
Conversation
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| "ContentGraph": { | ||
| "GatewayAddress": "https://cg.optimizely.com", | ||
| "AppKey": "rIekX0Q5KkIDqxaSfaI3XeiaISjVWOGWHaSRAxvTaMDqfsQX", | ||
| "Secret": "nEOnBZnlpP8WxaJHzfDD40hRmOjVX5QxFiqJb5KO2icVK5+r2Eu+jqH6lKYqDfTg", |
| "ContentGraph": { | ||
| "GatewayAddress": "https://cg.optimizely.com", | ||
| "AppKey": "rIekX0Q5KkIDqxaSfaI3XeiaISjVWOGWHaSRAxvTaMDqfsQX", | ||
| "Secret": "nEOnBZnlpP8WxaJHzfDD40hRmOjVX5QxFiqJb5KO2icVK5+r2Eu+jqH6lKYqDfTg", |
| } | ||
|
|
||
| [HttpPost] | ||
| public IActionResult Create([FromBody] CreateCategoryRequest request) |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request upgrades the project to .NET 10 and Optimizely CMS 13, adding a new submodule and updating the solution structure while removing a large volume of legacy sandbox files. Feedback on these changes highlights several improvements: updating .gitmodules to track a stable branch instead of a temporary upgrade branch, fixing a malformed markdown link in the README.md platform badge, updating several projects in the solution file to use modern SDK-style GUIDs instead of legacy C# GUIDs, and ensuring the main projects are correctly nested under the newly added src solution folder.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| [submodule "sub/geta-foundation-core"] | ||
| path = sub/geta-foundation-core | ||
| url = https://github.com/Geta/geta-foundation-core | ||
| branch = upgrade/cms13-2 |
There was a problem hiding this comment.
Tracking a temporary feature/upgrade branch (upgrade/cms13-2) in .gitmodules is risky because once the upgrade is merged and the branch is deleted, future submodule updates tracking this branch will fail. It is recommended to track a stable branch (e.g., main or master) or remove the branch configuration entirely to default to the repository's default branch.
branch = main
| [](https://sonarcloud.io/summary/new_code?id=Geta_geta-optimizely-categories) | ||
| [)](https://docs.microsoft.com/en-us/dotnet/) | ||
| [](http://world.episerver.com/cms/) | ||
| [)](https://docs.microsoft.com/en-us/dotnet/) |
There was a problem hiding this comment.
The markdown link for the .NET platform badge is malformed and contains nested/mismatched brackets and parentheses. It should be simplified to a standard markdown link format.
| [)](https://docs.microsoft.com/en-us/dotnet/) | |
| [](https://docs.microsoft.com/en-us/dotnet/) |
| MinimumVisualStudioVersion = 10.0.40219.1 | ||
| Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Geta.Optimizely.Categories", "src\Geta.Optimizely.Categories\Geta.Optimizely.Categories.csproj", "{B98D1645-CBE3-4466-BCDA-09B0E4044449}" | ||
| EndProject | ||
| Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Geta.Optimizely.Categories.Web", "src\Geta.Optimizely.Categories.Web\Geta.Optimizely.Categories.Web.csproj", "{A1B2C3D4-E5F6-7890-ABCD-EF1234567890}" |
There was a problem hiding this comment.
The project Geta.Optimizely.Categories.Web is configured with the legacy C# project type GUID ({FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}). Since this is a modern .NET project, it should use the SDK-style project type GUID ({9A19103F-16F7-4668-BE54-9A1E7A4F7556}) for consistency and better tooling support.
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Geta.Optimizely.Categories.Web", "src\Geta.Optimizely.Categories.Web\Geta.Optimizely.Categories.Web.csproj", "{A1B2C3D4-E5F6-7890-ABCD-EF1234567890}"
| EndProject | ||
| Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "geta-foundation-core", "geta-foundation-core", "{637F7C28-82DB-4DFA-ADB4-B6061538FC11}" | ||
| EndProject | ||
| Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Foundation", "sub\geta-foundation-core\src\Foundation\Foundation.csproj", "{482B37E4-8CBF-426A-865C-8AB7E4E145DA}" |
There was a problem hiding this comment.
The project Foundation is configured with the legacy C# project type GUID ({FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}). It should be updated to use the SDK-style project type GUID ({9A19103F-16F7-4668-BE54-9A1E7A4F7556}).
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Foundation", "sub\geta-foundation-core\src\Foundation\Foundation.csproj", "{482B37E4-8CBF-426A-865C-8AB7E4E145DA}"
| EndProject | ||
| Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Foundation", "sub\geta-foundation-core\src\Foundation\Foundation.csproj", "{482B37E4-8CBF-426A-865C-8AB7E4E145DA}" | ||
| EndProject | ||
| Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Foundation.AppHost", "sub\geta-foundation-core\src\Foundation.AppHost\Foundation.AppHost.csproj", "{21873564-1FF0-41B3-B9EE-3D1EAF274763}" |
There was a problem hiding this comment.
The project Foundation.AppHost is configured with the legacy C# project type GUID ({FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}). It should be updated to use the SDK-style project type GUID ({9A19103F-16F7-4668-BE54-9A1E7A4F7556}).
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Foundation.AppHost", "sub\geta-foundation-core\src\Foundation.AppHost\Foundation.AppHost.csproj", "{21873564-1FF0-41B3-B9EE-3D1EAF274763}"
| EndProject | ||
| Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Foundation.AppHost", "sub\geta-foundation-core\src\Foundation.AppHost\Foundation.AppHost.csproj", "{21873564-1FF0-41B3-B9EE-3D1EAF274763}" | ||
| EndProject | ||
| Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Foundation.AppHost.ServiceDefaults", "sub\geta-foundation-core\src\Foundation.AppHost.ServiceDefaults\Foundation.AppHost.ServiceDefaults.csproj", "{FF8CF906-96C1-4205-8E53-CFE933F054A2}" |
There was a problem hiding this comment.
The project Foundation.AppHost.ServiceDefaults is configured with the legacy C# project type GUID ({FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}). It should be updated to use the SDK-style project type GUID ({9A19103F-16F7-4668-BE54-9A1E7A4F7556}).
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Foundation.AppHost.ServiceDefaults", "sub\geta-foundation-core\src\Foundation.AppHost.ServiceDefaults\Foundation.AppHost.ServiceDefaults.csproj", "{FF8CF906-96C1-4205-8E53-CFE933F054A2}"
| EndProject | ||
| Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "tests", "tests", "{0AB3BF05-4346-4AA6-1389-037BE0695223}" | ||
| EndProject | ||
| Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Geta.Optimizely.Categories.Tests", "tests\Geta.Optimizely.Categories.Tests\Geta.Optimizely.Categories.Tests.csproj", "{08CA7750-BA09-4987-BC55-2D6F7638C381}" |
There was a problem hiding this comment.
The project Geta.Optimizely.Categories.Tests is configured with the legacy C# project type GUID ({FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}). It should be updated to use the SDK-style project type GUID ({9A19103F-16F7-4668-BE54-9A1E7A4F7556}).
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Geta.Optimizely.Categories.Tests", "tests\Geta.Optimizely.Categories.Tests\Geta.Optimizely.Categories.Tests.csproj", "{08CA7750-BA09-4987-BC55-2D6F7638C381}"
| GlobalSection(NestedProjects) = preSolution | ||
| {482B37E4-8CBF-426A-865C-8AB7E4E145DA} = {637F7C28-82DB-4DFA-ADB4-B6061538FC11} | ||
| {21873564-1FF0-41B3-B9EE-3D1EAF274763} = {637F7C28-82DB-4DFA-ADB4-B6061538FC11} | ||
| {FF8CF906-96C1-4205-8E53-CFE933F054A2} = {637F7C28-82DB-4DFA-ADB4-B6061538FC11} | ||
| {08CA7750-BA09-4987-BC55-2D6F7638C381} = {0AB3BF05-4346-4AA6-1389-037BE0695223} | ||
| EndGlobalSection |
There was a problem hiding this comment.
The solution folder src (GUID {827E0CD3-B72D-47B6-A68D-7590B98EB39B}) was added to the solution, but the main projects Geta.Optimizely.Categories (GUID {B98D1645-CBE3-4466-BCDA-09B0E4044449}) and Geta.Optimizely.Categories.Web (GUID {A1B2C3D4-E5F6-7890-ABCD-EF1234567890}) are not nested under it in the NestedProjects section. This will cause them to appear at the root of the solution in the IDE instead of inside the src folder.
2 participants
Upgrade to cms 13