Skip to content

Feature: Allow to change the maximum stack size of custom vanilla item mappings#5241

Closed
BUGTeas wants to merge 4 commits into
GeyserMC:masterfrom
BUGTeas:feature/custom-max-stack-size
Closed

Feature: Allow to change the maximum stack size of custom vanilla item mappings#5241
BUGTeas wants to merge 4 commits into
GeyserMC:masterfrom
BUGTeas:feature/custom-max-stack-size

Conversation

@BUGTeas

@BUGTeas BUGTeas commented Dec 23, 2024

Copy link
Copy Markdown
Contributor

Now Java editon have the max_stack_size component to allow user change the maximum stack size of vanilla items butween 1~99. But Bedrock only support it in addon-defined items, so it's imperfect use.

This pull allow to customize the maximum stack size during the Bedrock item registration. to improve the experience as much as possible.

Example usage of this pull

JSON mappings:

{
  "format_version": "1",
    "items": {
      "minecraft:snowball": [
      {
        "custom_model_data": 101,
        "name": "custom_snowball",
        "max_stack_size": 64
      }
    ]
}

Extension API:

CustomItemData data = CustomItemData.builder()
        .name("custom_snowball")
        .customItemOptions(itemOptions)
        .stackSize(64)
        .build();

@onebeastchris

Copy link
Copy Markdown
Member

Hello! Thanks for the PR.
However, the V2 version of the custom items api that is currently in the works - see #5189 for reference - will already implement this feature, and when it releases, the current custom item api (v1) will be deprecated in favor of the new version . Thank you anyways!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants