Refactor: use a compiled pattern for skin hash validation#5523
Merged
onebeastchris merged 4 commits intoSep 29, 2025
Merged
Conversation
Member
|
How's this looking? Ready for review? :) |
onebeastchris
approved these changes
Sep 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using Pattern.compile() vs matches() for Regular Expressions in Java
This PR optimizes the memory usage for reset pattern in Java.
Why Pattern.compile() is Preferred Over matches()
When working with regular expressions in Java, using
Pattern.compile()is significantly more efficient thanmatches()for several reasons:Performance Optimization:
matches()recompiles the regex pattern on each call, whilePattern.compile()only compiles it once.Memory Efficiency: Precompiled patterns reduce memory usage and garbage collection overhead.
Reusability: A compiled pattern can be reused across multiple operations.
According to the Java documentation,
String.matches()internally creates a newPatternobject each time it's called.