Some fixes for potion items by BUGTeas · Pull Request #5555 · GeyserMC/Geyser

BUGTeas · 2025-05-17T15:50:46Z

Add some code comments about:
- Feature：Make custom effect information visible & Support for customizing item name via 'custom_name' tag in 'potion_contents' component (new feature since 1.21.2) #5176
- Fix item_name component not work; Improve display of custom effects and shulker box tooltips for item names #5255
Remove the incorrect prefix correctly in potion name
Example: /give @s potion[potion_contents={potion:long_leaping,custom_effects:[{id:luck}]}]
->
Fix tipped arrow always using name "Tipped Arrow" and not affected by potion components
Example: /give @s minecraft:tipped_arrow[potion_contents={potion:leaping}]
->
Fix the wrong Bedrock ID of tipped arrows in the tooltip of shulker box
Example: /give @s minecraft:shulker_box[container=[{slot:0,item:{id:tipped_arrow,count:1,components:{potion_contents:{potion:leaping}}}}]]
->
Optimize potion name when potion tooltip is hidden
Able to display ~~potion effects~~ custom potion effects in ~~normal arrow item~~ all items just like Java Edition
Example: /give @s apple[potion_contents={custom_effects:[{id:luck}]}]
Add minecraft:potion_duration_scale component support (new feature since 1.21.5)

…on name, fix potion name in tipped arrows (refs GeyserMC#5255 GeyserMC#5176)

… potion components

…etting potion name in the getPotionName method?

eclipseisoffline · 2025-05-17T17:37:18Z

-            // Make custom effect information visible when shown in tooltip
-            if (potionContents != null && tooltip.showInTooltip(DataComponentTypes.POTION_CONTENTS)) {
-                customName += getPotionEffectInfo(potionContents, session.locale()); // TODO should this be done with lore instead?
+            if (javaItem instanceof PotionItem || javaItem instanceof ArrowItem) {


Any reason for adding this instanceof check? Geyser tries to match Java behaviour, and Java shows the potion effect tooltip on all items with a potion_contents component, not just these specific items, so it's probably good to do the same.

Also, given the above, I'm not sure if Geyser should show the effect in the HUD name tooltip, since Java doesn't. However, that seems up to debate to me.

Reason for show the effects in the HUD name tooltip

Bedrock always show effects in the HUD name tooltip, and show "No Effects" when it haven't any effects. If use lore to show these custom effects, Bedrock player will only saw effects or "No Effects" by vanilla potion ID.

/give @s potion[custom_name="Test",potion_contents={custom_effects:[{id:hero_of_the_village,duration:-1},{id:unluck,amplifier:1,duration:658980}]}]

/give @s potion[custom_name="Test 2",potion_contents={custom_effects:[{id:hero_of_the_village,duration:-1},{id:unluck,amplifier:1,duration:658980}],potion:leaping}]

But wrapping line in name can resolve this problem well:

At least, It reduce some misunderstandings of players, even if it looks a little wried.

So, is the instanceof check before getting potion name in the getPotionName method used to use the custom_name of the potion_contents component only on tipped arrow & potion to match the Java behavior? I understand now.

For show custom effects on next line of the name, I think it have a better method to implement this. I'll take a look at it later.

Bedrock always show effects in the HUD name tooltip, and show "No Effects" when it haven't any effects. If use lore to show these custom effects, Bedrock player will only saw effects or "No Effects" by vanilla potion ID.

Ah okay, thanks for clarifying! In that case, this makes sense to me. It might be good to document this in comments near the code as well, for future reference.

…, like getting potion name in the getPotionName method?" This reverts commit c002361.

…ame when potion tooltip is hidden

… box tooltip

…since 1.21.5)

…potion-component

onebeastchris · 2025-07-04T22:45:56Z

Heya, what's the holdup here? 😄

BUGTeas · 2025-07-06T04:31:18Z

Heya, what's the holdup here? 😄

I deeply apologize, but I don't have time to continue this work for the time being. I will add some commit directly when I come back in future.

…omponent

BUGTeas · 2025-08-05T15:04:25Z

Sorry I took too long. Now it can be review.

onebeastchris

Apologies for the wait, I forgot about this PR 😬

onebeastchris · 2026-03-24T00:08:09Z


            Set<Item> javaOnlyItems = new ObjectOpenHashSet<>();
            Collections.addAll(javaOnlyItems, Items.SPECTRAL_ARROW, Items.DEBUG_STICK,
-                    Items.KNOWLEDGE_BOOK, Items.TIPPED_ARROW);


To my knowledge, this item still doesn't exist - at least not the base tipped arrow. Can we account for that?

onebeastchris · 2026-03-24T00:09:01Z

            // Make a name when has custom effects
-            String potionName = potion == null ? "empty" : potion.toString().toLowerCase(Locale.ROOT);
-            return MessageTranslator.convertMessage(Component.translatable(mapping.getJavaItem().translationKey() + ".effect." + potionName), language);
+            // because the custom effect information is display from the second line of the name.


Suggested change

// because the custom effect information is display from the second line of the name.

// The custom effect information is displayed in the second line of the name.

onebeastchris · 2026-03-24T00:09:17Z

-            String potionName = potion == null ? "empty" : potion.toString().toLowerCase(Locale.ROOT);
-            return MessageTranslator.convertMessage(Component.translatable(mapping.getJavaItem().translationKey() + ".effect." + potionName), language);
+            // because the custom effect information is display from the second line of the name.
+            // if name is not set, the custom effect information will not be displayed.


Suggested change

// if name is not set, the custom effect information will not be displayed.

// If a name is not set, the custom effect information will not be displayed.

BUGTeas added 4 commits May 17, 2025 11:17

Add some code comments, remove the incorrect prefix correctly in poti…

bb98765

…on name, fix potion name in tipped arrows (refs GeyserMC#5255 GeyserMC#5176)

Fix tipped arrow always using name "Tipped Arrow" and not affected by…

989eb71

… potion components

Fix the wrong Bedrock ID of tipped arrows in the tooltip of shulker box

d038c66

Is necessary to check the type of Item to improve performance, like g…

c002361

…etting potion name in the getPotionName method?

eclipseisoffline reviewed May 17, 2025

View reviewed changes

BUGTeas added 4 commits May 18, 2025 11:45

Revert "Is necessary to check the type of Item to improve performance…

02666f6

…, like getting potion name in the getPotionName method?" This reverts commit c002361.

Able to display custom potion effects in all items; Optimize potion n…

abf57ca

…ame when potion tooltip is hidden

Ensure potion displays the same name both its own tooltip and shulker…

f804eb1

… box tooltip

Add minecraft:potion_duration_scale component support (new feature …

19f202a

…since 1.21.5)

BUGTeas marked this pull request as ready for review May 23, 2025 16:59

Merge branch 'master' of https://github.com/GeyserMC/Geyser into fix-…

1f53fdf

…potion-component

BUGTeas marked this pull request as draft May 24, 2025 12:54

BUGTeas added 2 commits August 5, 2025 15:29

Merge branch 'master' of github.com:GeyserMC/Geyser into fix-potion-c…

22e8f32

…omponent

Improve access to potion names

31259a2

BUGTeas marked this pull request as ready for review August 5, 2025 14:59

Improve a little of code

e313a7a

eclipseisoffline mentioned this pull request Aug 30, 2025

Full Java tooltip parity (as much as that is possible) #5692

Open

onebeastchris requested changes Mar 24, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Some fixes for potion items#5555

Some fixes for potion items#5555
BUGTeas wants to merge 12 commits into
GeyserMC:masterfrom
BUGTeas:fix-potion-component

BUGTeas commented May 17, 2025 •

edited

Loading

Uh oh!

eclipseisoffline May 17, 2025

Uh oh!

BUGTeas May 18, 2025

Uh oh!

BUGTeas May 18, 2025 •

edited

Loading

Uh oh!

eclipseisoffline May 18, 2025

Uh oh!

Uh oh!

onebeastchris commented Jul 4, 2025

Uh oh!

BUGTeas commented Jul 6, 2025

Uh oh!

BUGTeas commented Aug 5, 2025

Uh oh!

onebeastchris left a comment

Uh oh!

onebeastchris Mar 24, 2026

Uh oh!

onebeastchris Mar 24, 2026

Uh oh!

onebeastchris Mar 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	// because the custom effect information is display from the second line of the name.
	// The custom effect information is displayed in the second line of the name.

	// if name is not set, the custom effect information will not be displayed.
	// If a name is not set, the custom effect information will not be displayed.

Uh oh!

Conversation

BUGTeas commented May 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eclipseisoffline May 17, 2025

Choose a reason for hiding this comment

Uh oh!

BUGTeas May 18, 2025

Choose a reason for hiding this comment

Reason for show the effects in the HUD name tooltip

Uh oh!

BUGTeas May 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

eclipseisoffline May 18, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

onebeastchris commented Jul 4, 2025

Uh oh!

BUGTeas commented Jul 6, 2025

Uh oh!

BUGTeas commented Aug 5, 2025

Uh oh!

onebeastchris left a comment

Choose a reason for hiding this comment

Uh oh!

onebeastchris Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

onebeastchris Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

onebeastchris Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

BUGTeas commented May 17, 2025 •

edited

Loading

BUGTeas May 18, 2025 •

edited

Loading