Fix: hide living entity name when it is a vehicle#6290
Merged
onebeastchris merged 3 commits intoApr 8, 2026
Conversation
Novampr
approved these changes
Apr 7, 2026
Novampr
left a comment
Novampr
left a comment
Contributor
There was a problem hiding this comment.
lgtm, let's hope the master ci build is fixed soon xd
|
2026-04-10-8.log |
Contributor
|
Please make a new GitHub issue or ask in the support channels in the GeyserMC Discord server. This is a pull request not an ask for support post. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The name tag of a living entity is always hidden when it is a vehicle on Java edition (see:
LivingEntityRenderer, line 236). This is currently not implemented in Geyser, which can create issues, especially when using a plugin or mod that customises the way player names are shown above players, by creating a text display mounted on a player.This PR implements this behaviour within Geyser. It has been tested using the Fabric Custom Names mod.