Eliminate ByteBuf copy in chunk translator#6311
Merged
onebeastchris merged 1 commit intoApr 21, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to reduce chunk translation overhead by removing an intermediate byte[] copy when building the Bedrock LevelChunkPacket, instead passing a Netty ByteBuf slice directly.
Changes:
- Removes copying
ByteBufcontents into abyte[]and wrapping it again for the packet payload. - Sends
LevelChunkPacketwithbyteBuf.retainedSlice()as the data payload. - Switches the output buffer allocation from
ByteBufAllocator.DEFAULT.ioBuffer(size)toUnpooled.buffer(size).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ByteExceptionM
deleted the
feature/eliminate-bytebuf-copy-chunk-translator
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The chunk translator was copying the ByteBuf into a byte array and then wrapping it again into a new buffer for the packet. That means every chunk that gets sent briefly exists twice in memory. Removed that extra copy by passing the buffer directly to the packet via
retainedSlice(). This cuts memory usage per chunk in half during translation and reduces GC pressure, especially noticeable when players are loading lots of chunks at once.