Skip to content

Eliminate ByteBuf copy in chunk translator #6311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
onebeastchris merged 1 commit into from
Apr 21, 2026
+10 −15
Merged

Eliminate ByteBuf copy in chunk translator #6311

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 10 additions & 15 deletions ...org/geysermc/geyser/translator/protocol/java/level/JavaLevelChunkWithLightTranslator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@
package org.geysermc.geyser.translator.protocol.java.level;

import io.netty.buffer.ByteBuf;
import io.netty.buffer.ByteBufAllocator;
import io.netty.buffer.ByteBufOutputStream;
import io.netty.buffer.Unpooled;
import it.unimi.dsi.fastutil.ints.IntArrayList;
Expand Down Expand Up @@ -106,7 +105,6 @@ public void translate(GeyserSession session, ClientboundLevelChunkWithLightPacke
int maxBedrockSectionY = (bedrockDimension.height() >> 4) - 1;

int sectionCount;
byte[] payload;
ByteBuf byteBuf = null;

// calculate the difference between the java dimension minY and the bedrock dimension minY as
Expand Down Expand Up @@ -340,7 +338,7 @@ public void translate(GeyserSession session, ClientboundLevelChunkWithLightPacke
size += bedrockBlockEntities.size() * 64; // Conservative estimate of 64 bytes per tile entity

// Allocate output buffer
byteBuf = ByteBufAllocator.DEFAULT.ioBuffer(size);
byteBuf = Unpooled.buffer(size);
for (int i = 0; i < sectionCount; i++) {
GeyserChunkSection section = sections[i];
if (section != null) {
Expand Down Expand Up @@ -376,26 +374,23 @@ public void translate(GeyserSession session, ClientboundLevelChunkWithLightPacke
for (NbtMap blockEntity : bedrockBlockEntities) {
nbtStream.writeTag(blockEntity);
}
payload = new byte[byteBuf.readableBytes()];
byteBuf.readBytes(payload);
LevelChunkPacket levelChunkPacket = new LevelChunkPacket();
levelChunkPacket.setSubChunksLength(sectionCount);
levelChunkPacket.setCachingEnabled(false);
levelChunkPacket.setChunkX(packet.getX());
levelChunkPacket.setChunkZ(packet.getZ());
levelChunkPacket.setData(byteBuf.retainedSlice());
levelChunkPacket.setDimension(session.getBedrockDimension().bedrockId());
session.sendUpstreamPacket(levelChunkPacket);
Comment thread
ByteExceptionM marked this conversation as resolved.
} catch (IOException e) {
session.getGeyser().getLogger().error("IO error while encoding chunk", e);
return;
} finally {
if (byteBuf != null) {
byteBuf.release(); // Release buffer to allow buffer pooling to be useful
byteBuf.release();
}
}

LevelChunkPacket levelChunkPacket = new LevelChunkPacket();
levelChunkPacket.setSubChunksLength(sectionCount);
levelChunkPacket.setCachingEnabled(false);
levelChunkPacket.setChunkX(packet.getX());
levelChunkPacket.setChunkZ(packet.getZ());
levelChunkPacket.setData(Unpooled.wrappedBuffer(payload));
levelChunkPacket.setDimension(session.getBedrockDimension().bedrockId());
session.sendUpstreamPacket(levelChunkPacket);

for (Map.Entry<Vector3i, ItemFrameEntity> entry : session.getItemFrameCache().entrySet()) {
Vector3i position = entry.getKey();
if ((position.getX() >> 4) == packet.getX() && (position.getZ() >> 4) == packet.getZ()) {
Expand Down
Loading