Avoid re-sending potion mixes in quick succession#6372
Merged
onebeastchris merged 3 commits intoMay 11, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Reduces Bedrock-side load delays by avoiding re-sending the full “clean” CraftingDataPacket payload (cartography recipes + potion mixes + cached recipes) when ClientboundUpdateRecipesPacket arrives shortly after the configuration phase.
Changes:
- Conditionally sends “base” recipe data in
JavaUpdateRecipesTranslatorbased on a new session flag (cleanRecipesRequired). - Sets
cleanRecipesRequiredtofalseafterJavaFinishConfigurationTranslatorsends the initial clean recipe packet, so the next update can be incremental. - Initializes recipe-related session maps/fields with defaults in
GeyserSession(including the new flag).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| core/src/main/java/org/geysermc/geyser/translator/protocol/java/JavaUpdateRecipesTranslator.java | Avoids re-sending base recipe data unless a clean reset is required. |
| core/src/main/java/org/geysermc/geyser/translator/protocol/java/JavaFinishConfigurationTranslator.java | Sends the initial clean recipe packet and disables subsequent immediate clean resend. |
| core/src/main/java/org/geysermc/geyser/session/GeyserSession.java | Adds cleanRecipesRequired state and adjusts recipe map initialization defaults. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent testing showed that re-sending "clean" CraftingDataPackets rapidly - e.g. on join with a backend server switch - could cause clients to load worlds much slower. This patch partially avoids this by adding onto existing recipes (sent when the configuration stage finishes) upon receiving the
ClientboundUpdateRecipesPacketinstead of always re-sending the full packet.