Fix javaY precision#6435
Merged
Merged
Conversation
Camotoy
reviewed
May 30, 2026
| EntityDefinition<AvatarEntity> avatarEntityBase = EntityDefinition.<AvatarEntity>inherited(null, livingEntityBase) | ||
| .height(1.8f).width(0.6f) | ||
| .offset(1.62f) | ||
| .offset(1.62001f) |
Member
There was a problem hiding this comment.
Let's mark why we're doing this? E.G. "Player offset sent by Bedrock. Verified on Bedrock 26.23".
onebeastchris
requested changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous solution caused coordinates like
70.9999999816513. With this change, coordinates are now correctly71.0and the previous y=2 bug remains fixed.Also reverts a change that made player offsets
1.62finstead of1.62001f. The bedrock player still sends an offset of1.62001fwhich can be shown by printing the packet position they send.