Fix network handler order#6436
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the Netty pipeline ordering for RakNet-related handlers in GeyserServer so RakConnectionRequestHandler runs immediately before RakServerOfflineHandler, ensuring it executes after the proxy protocol handler and connection throttler.
Changes:
- Insert
RakConnectionRequestHandlerusingaddBefore(RakServerOfflineHandler.NAME, ...)instead ofaddFirst(...)to enforce correct handler ordering.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
valaphee
force-pushed
the
fix-handler-order
branch
from
bbe3944 to
c70a279
Compare
onebeastchris
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the RakConnectionRequestHandler directly in front of the RakServerOfflineHandler, and this way after the proxy protocol handler and connection throttler.