Escape percent signs where necessary#6437
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR escapes literal percent signs in Bedrock-bound text fields where % can be interpreted as translation placeholders, preserving intended display text.
Changes:
- Escapes percent signs in combat death screen messages.
- Escapes percent signs in boss bar titles.
- Escapes percent signs in scoreboard objective display names.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
JavaPlayerCombatKillTranslator.java |
Escapes % in death info cause text before sending to Bedrock. |
BossBar.java |
Escapes % in boss bar create/update title packets. |
Objective.java |
Escapes % in scoreboard objective display names. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
onebeastchris
approved these changes
May 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Percent signs are used for translatables in Bedrock at some places, which we don't need