Strip color codes from messages where they aren't supported anymore#6438
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses Bedrock clients no longer supporting color formatting in certain UI contexts (notably the disconnect screen), by converting formatted/legacy text into plain text before it is displayed.
Changes:
- Convert Java server ping description (passthrough MOTD) to plain text before splitting into MOTD/sub-MOTD lines.
- Convert disconnect reason
Componentto plain text before passing it through theSessionDisconnectEventAPI.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| core/src/main/java/org/geysermc/geyser/network/netty/GeyserServer.java | Uses plain-text conversion for passthrough MOTD derived from Java ping description. |
| core/src/main/java/org/geysermc/geyser/event/type/SessionDisconnectEventImpl.java | Ensures disconnect reasons passed to the event/UI are plain text (no formatting codes). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
onebeastchris
approved these changes
Jun 1, 2026
valaphee
force-pushed
the
strip-color-codes
branch
from
1c39c1c to
2d86055
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6426