Add custom skull JSON mappings and deprecate custom-skulls.yml file#6481
Open
eclipseisoffline wants to merge 3 commits into
Open
Add custom skull JSON mappings and deprecate custom-skulls.yml file#6481eclipseisoffline wants to merge 3 commits into
eclipseisoffline wants to merge 3 commits into
Conversation
onebeastchris
approved these changes
Jun 26, 2026
3 tasks
eclipseisoffline
changed the title
| return paths | ||
| .filter(child -> child.toString().endsWith(".json")) | ||
| .toArray(Path[]::new); | ||
| } catch (IOException e) { |
Member
There was a problem hiding this comment.
Probably worth logging a message here if one exists?
|
|
||
| Gson gson = new GsonBuilder().setPrettyPrinting().create(); | ||
| MappingsConfigReader.getCustomMappingsDirectoryAndEnsureItExists().ifPresentOrElse(mappingsDirectory -> { | ||
| Path destination = mappingsDirectory.resolve("migrated-custom-skulls.yml.json"); |
Member
There was a problem hiding this comment.
errrrrrr this looks a bit funny; why not drop the .yml?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new JSON custom mappings type,
skulls, which functions exactly like thecustom-skulls.ymlfile, but in JSON mappings form, which makes it easier for converters like Rainbow to automatically generate custom skull mappings without conflicting with each other.Custom skull mappings look like this:
{ "format_version": 1, "skulls": { "username": [ "Steve" ], "uuid": [ "f84c6a79-0a4e-45e0-879b-cd49ebd4c4e2" ], "profile": [ "ewogICJ0aW1lc3RhbXAiIDogMTc4MjQ2MjA4MzQ2NiwKICAicHJvZmlsZUlkIiA6ICI4NTNjODBlZjNjMzc0OWZkYWE0OTkzOGI2NzRhZGFlNiIsCiAgInByb2ZpbGVOYW1lIiA6ICJqZWJfIiwKICAidGV4dHVyZXMiIDogewogICAgIlNLSU4iIDogewogICAgICAidXJsIiA6ICJodHRwOi8vdGV4dHVyZXMubWluZWNyYWZ0Lm5ldC90ZXh0dXJlLzdmZDliYTQyYTdjODFlZWVhMjJmMTUyNDI3MWFlODVhOGUwNDVjZTBhZjVhNmFlMTZjNjQwNmFlOTE3ZTY4YjUiCiAgICB9LAogICAgIkNBUEUiIDogewogICAgICAidXJsIiA6ICJodHRwOi8vdGV4dHVyZXMubWluZWNyYWZ0Lm5ldC90ZXh0dXJlLzllNTA3YWZjNTYzNTk5NzhhM2ViM2UzMjM2NzA0MmI4NTNjZGRkMDk5NWQxN2QwZGE5OTU2NjI5MTNmYjAwZjciCiAgICB9CiAgfQp9" ], "skin_hash": [ "50c410fad8d9d8825ad56b0e443e2777a6b46bfa20dacd1d2f55edc71fbeb06d" ] } }Texture strings may not be empty. When an unknown texture type is read, an appropriate error is thrown:
The
custom-skulls.ymlconfig file has turned legacy and is deprecated. Geyser will automatically attempt to migrate it to a JSON skull mappings file upon boot.