fix: use firmware pid for IsPro/IsAD5X detection

The /detail `name` field is user-mutable, so renaming a printer broke
model detection. `pid` is firmware-set and stable.

Also exposes Pid on FFMachineInfo. Bumps to 1.3.1.

Refs: GhostTypes/ff-5mp-hass#13

Author: GhostTypes

CHANGELOG.md

@@ -7,6 +7,20 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [1.3.1] - 2026-05-08
+
+### Fixed
+
+- Printer model detection (`IsPro`, `IsAD5X` on `FFMachineInfo`) now reads the firmware-set integer `pid` field on `/detail` instead of string-matching the user-mutable `name` field. Renaming an Adventurer 5M / 5M Pro / AD5X via the LCD or cloud no longer breaks model detection in downstream consumers (Electron UI, Web UI). Falls back to the legacy name+capability heuristic when `pid` is absent so older firmware still works. Reported in [ff-5mp-hass#13](https://github.com/GhostTypes/ff-5mp-hass/issues/13).
+
+### Added
+
+- `FFMachineInfo.Pid: number | undefined` — the raw firmware PID exposed for consumers that want to do their own model-class gating. Known modern HTTP-capable PIDs: `35` (Adventurer 5M), `36` (5M Pro), `38` (AD5X).
+
+### Changed
+
+- Corrected misleading JSDoc on `FFPrinterDetail.pid` (was "Process ID, possibly related to the current print job"; it is in fact the firmware-set Product ID).
+
 ## [1.3.0] - 2026-03-21
 
 ### Added

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ghosttypes/ff-api",
-  "version": "1.3.0",
+  "version": "1.3.1",
   "description": "FlashForge 3D Printer API for Node.js",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",

src/models/MachineInfo.test.ts

@@ -215,6 +215,76 @@ describe('MachineInfo', () => {
       expect(result.IsPro).toBe(true);
     });
 
+    it('should detect AD5X from pid when renamed without matl_station fields', () => {
+      // Regression test for ff-5mp-hass#13: a user renamed their printer and
+      // the name+capability fallback could no longer recognize the model.
+      // The firmware-set integer pid is stable across renames.
+      const renamedAd5x: FFPrinterDetail = {
+        name: 'LegoTech82',
+        pid: 38,
+        firmwareVersion: '1.1.7-1.0.2',
+        ipAddr: '192.168.1.120',
+        status: 'ready',
+      };
+
+      const result = machineInfoConverter.fromDetail(renamedAd5x);
+
+      expect(result).not.toBeNull();
+      if (!result) return;
+      expect(result.Name).toBe('LegoTech82');
+      expect(result.Pid).toBe(38);
+      expect(result.IsAD5X).toBe(true);
+      expect(result.IsPro).toBe(false);
+    });
+
+    it('should detect 5M Pro from pid even when renamed', () => {
+      const renamedPro: FFPrinterDetail = {
+        ...GENERIC_PRINTER_DETAIL_JSON,
+        name: 'MyPrinter',
+        pid: 36,
+      };
+
+      const result = machineInfoConverter.fromDetail(renamedPro);
+
+      expect(result).not.toBeNull();
+      if (!result) return;
+      expect(result.Name).toBe('MyPrinter');
+      expect(result.Pid).toBe(36);
+      expect(result.IsPro).toBe(true);
+      expect(result.IsAD5X).toBe(false);
+    });
+
+    it('should treat pid 35 as a plain 5M even if name suggests Pro', () => {
+      const plain5M: FFPrinterDetail = {
+        ...GENERIC_PRINTER_DETAIL_JSON,
+        name: 'FlashForge 5M Pro',
+        pid: 35,
+      };
+
+      const result = machineInfoConverter.fromDetail(plain5M);
+
+      expect(result).not.toBeNull();
+      if (!result) return;
+      expect(result.Pid).toBe(35);
+      expect(result.IsPro).toBe(false);
+      expect(result.IsAD5X).toBe(false);
+    });
+
+    it('should fall back to name+capability when pid is absent', () => {
+      const noPidAd5x: FFPrinterDetail = {
+        ...AD5X_PRINTER_DETAIL_JSON,
+        pid: undefined,
+      };
+
+      const result = machineInfoConverter.fromDetail(noPidAd5x);
+
+      expect(result).not.toBeNull();
+      if (!result) return;
+      expect(result.Pid).toBeUndefined();
+      expect(result.IsAD5X).toBe(true); // detected via hasMatlStation fallback
+      expect(result.IsPro).toBe(false);
+    });
+
     it('should return null if detail is null', () => {
       const result = machineInfoConverter.fromDetail(null);
       expect(result).toBeNull();

src/models/MachineInfo.ts

@@ -3,6 +3,13 @@
  */
 import { type FFMachineInfo, type FFPrinterDetail, MachineState } from './ff-models';
 
+// Firmware-reported PIDs from FlashForge's /detail endpoint. These are stable
+// identifiers set by firmware, unlike the user-mutable `name` field.
+const PID_5M = 35;
+const PID_5M_PRO = 36;
+const PID_AD5X = 38;
+const KNOWN_HTTP_PIDS = new Set<number>([PID_5M, PID_5M_PRO, PID_AD5X]);
+
 /**
  * Transforms printer detail data from the API response format into a structured `FFMachineInfo` object.
  * This class centralizes the logic for mapping and calculating various properties of the printer's state
@@ -33,8 +40,19 @@ export class MachineInfo {
         detail.hasMatlStation === true ||
         (detail.matlStationInfo?.slotCnt ?? 0) > 0 ||
         (detail.matlStationInfo?.slotInfos?.length ?? 0) > 0;
-      const isAD5X = detail.name === 'AD5X' || hasMaterialStation;
-      const isPro = (detail.name || '').includes('Pro') && !isAD5X;
+      const pid = detail.pid;
+      let isAD5X: boolean;
+      let isPro: boolean;
+      if (pid !== undefined && KNOWN_HTTP_PIDS.has(pid)) {
+        isAD5X = pid === PID_AD5X;
+        isPro = pid === PID_5M_PRO;
+      } else {
+        // Fallback for firmware that doesn't report pid: legacy
+        // name+capability heuristic. Vulnerable to user renames, which
+        // is why pid-based detection is preferred when available.
+        isAD5X = detail.name === 'AD5X' || hasMaterialStation;
+        isPro = (detail.name || '').includes('Pro') && !isAD5X;
+      }
       const printEta = this.formatTimeFromSeconds(detail.estimatedTime || 0);
       const completionTime = new Date(Date.now() + (detail.estimatedTime || 0) * 1000);
       const formattedRunTime = this.formatTimeFromSeconds(detail.printDuration || 0);
@@ -99,6 +117,7 @@ export class MachineInfo {
         FillAmount: detail.fillAmount || 0,
         FirmwareVersion: detail.firmwareVersion || '',
         Name: detail.name || '',
+        Pid: pid,
         IsPro: isPro,
         IsAD5X: isAD5X,
         NozzleSize: detail.nozzleModel || '',

src/models/ff-models.ts

@@ -89,7 +89,7 @@ export interface FFPrinterDetail {
   nozzleModel?: string;
   /** Style or type of the nozzle. */
   nozzleStyle?: number;
-  /** Process ID, possibly related to the current print job. */
+  /** Firmware-set Product ID identifying the printer model (e.g. 35=Adventurer 5M, 36=5M Pro, 38=AD5X). Stable across user renames. */
   pid?: number;
   /** Target temperature for the print bed (platform). */
   platTargetTemp?: number;
@@ -236,6 +236,8 @@ export interface FFMachineInfo {
   FirmwareVersion: string;
   /** User-configured name of the printer. */
   Name: string;
+  /** Firmware-set Product ID identifying the printer model (e.g. 35=Adventurer 5M, 36=5M Pro, 38=AD5X). Undefined on firmware that doesn't report it. */
+  Pid?: number;
   /** Indicates if the printer model is a "Pro" version. */
   IsPro: boolean;
   /** Indicates if the printer is an AD5X model. */