Shared repository folder item fix

[AmanPrasad43]

Description

Type of Change

• Bug fix - [ ] New feature - [ ] Breaking change - [ ] Plugin update

Checklist

• PR description clearly describes the changes
• Target branch is correct (master for features, Releases/* for fixes)
• Latest code from target branch merged
• No commented/junk code included
• No new build warnings or errors
• All existing unit tests pass
• New unit tests added for new functionality
• Cross-platform compatibility verified (Windows/Linux/macOS)
• CI/CD pipeline passes
• Code follows project conventions (Act{Platform}{Type}, {Platform}Driver)
• Repository objects use [IsSerializedForLocalRepository] where needed
• Error handling uses Reporter.ToLog() pattern
• Documentation updated for user-facing changes
• Self-review completed and code review comments addressed

Summary by CodeRabbit

• New Features
  • Repository folder tree views now automatically refresh and remain synchronized whenever items are added, removed, or modified, keeping the interface up-to-date.
  • Upload selection dialog now intelligently displays or hides the "Add to Folder" column based on upload operation type, providing a cleaner user experience.

[coderabbitai]

Caution

Review failed

Pull request was closed or merged during review

Walkthrough

This pull request refactors folder tree root initialization across repository pages by replacing direct instantiation with a factory-based approach, and adds dynamic refresh logic to UcListView to handle collection changes. Additionally, it introduces runtime-determined visibility for the "Add to Folder" column in UploadItemsSelectionPage based on item state.

Changes

Cohort / File(s)	Summary
Factory Method Refactoring ActionsRepositoryPage.xaml.cs, ActivitiesGroupsRepositoryPage.xaml.cs, ActivitiesRepositoryPage.xaml.cs	Replaced direct SetFolderTreeRoot() calls with SetFolderTreeRootFactory() to defer instantiation of folder tree root items via lambda factories.
UcListView Core Implementation UserControlsLib/UCListView/UcListView.xaml.cs	Added SetFolderTreeRootFactory() method with private factory field; integrated RefreshFolderTreeView() and RefreshExpandedTreeNodes() helpers to rebuild and refresh tree on collection changes and view toggles.
Dynamic Column Visibility UploadItemsSelectionPage.xaml.cs	Added event handlers and logic to dynamically show/hide "Add to Folder" column based on item state; introduces BoolToVisibilityInvertConverter class and wires collection/property change tracking.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

Possibly related PRs

• PR #4416: Introduces the initial SetFolderTreeRoot() calls that this PR refactors into factory-based SetFolderTreeRootFactory() across the same repository pages.
• PR #4419: Modifies shared-repository UI components with folder-view behavior; overlaps with UcListView and UploadItemsSelectionPage changes.

Suggested reviewers

• ravirk91
• tanushahande2003

Poem

🐰 A factory sprouts where roots once grew,
Deferred and lazy, fresh and new,
When collections change, the tree springs alive,
Columns dance in, visibility thrives,
Refresh and refactor, the pattern runs true! 🌳✨

🚥 Pre-merge checks | ❌ 3

❌ Failed checks (2 warnings, 1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The PR description is entirely empty except for the template structure—no actual description of changes, reasoning, or type of change is provided.	Add a detailed description explaining what was changed (factory-based initialization and visibility logic), why the changes were made, and which type of change applies (bug fix or new feature).
Docstring Coverage	⚠️ Warning	Docstring coverage is 4.76% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check	❓ Inconclusive	The title 'Shared repository folder item fix' is vague and generic, using non-specific language that doesn't clearly convey what problem is being fixed or what the main change accomplishes.	Clarify the title to be more specific. Examples: 'Implement factory-based folder tree root initialization' or 'Fix folder visibility in shared repository uploads'.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch BugFix/SharedRepoFolderRefresh

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (2)

Ginger/GingerCoreNET/Repository/SharedRepositoryOperations.cs (1)

161-174: ⚠️ Potential issue | 🔴 Critical

Prevent silent “success” when overwrite target folder cannot be resolved.

At Line [169], if GetRepositoryFolderByPath(targetFolderPath) returns null, the method still continues and later marks the upload as successful. In overwrite mode this can leave no current item in the intended location while returning success.

🔧 Proposed fix

                 if (isOverwrite)
                 {
-                    WorkSpace.Instance.SolutionRepository.MoveSharedRepositoryItemToPrevVersion(itemToUpload.ExistingItem);
-
                     // Checking if user selected a different target folder, using that, otherwise using existing folder
                     string targetFolderPath = itemToUpload.ExistingItem.ContainingFolderFullPath;
                     if (!string.IsNullOrEmpty(itemToUpload.TargetFolderFullPath) && 
                         itemToUpload.TargetFolderFullPath != itemToUpload.ExistingItem.ContainingFolderFullPath)
                     {
                         targetFolderPath = itemToUpload.TargetFolderFullPath;
                     }
 
-                    RepositoryFolderBase repositoryFolder = WorkSpace.Instance.SolutionRepository.GetRepositoryFolderByPath(targetFolderPath);
-                    if (repositoryFolder != null)
-                    {
-                        itemCopy.ItemName = itemToUpload.ExistingItem.ItemName;
-                        repositoryFolder.AddRepositoryItem(itemCopy);
-                    }
+                    RepositoryFolderBase repositoryFolder =
+                        WorkSpace.Instance.SolutionRepository.GetRepositoryFolderByPath(targetFolderPath)
+                        ?? WorkSpace.Instance.SolutionRepository.GetRepositoryFolderByPath(itemToUpload.ExistingItem.ContainingFolderFullPath);
+
+                    if (repositoryFolder == null)
+                    {
+                        Reporter.ToLog(eLogLevel.ERROR, $"Failed to resolve overwrite target folder path: {targetFolderPath}");
+                        itemToUpload.ItemUploadStatus = UploadItemSelection.eItemUploadStatus.FailedToUpload;
+                        return false;
+                    }
+
+                    WorkSpace.Instance.SolutionRepository.MoveSharedRepositoryItemToPrevVersion(itemToUpload.ExistingItem);
+                    itemCopy.ItemName = itemToUpload.ExistingItem.ItemName;
+                    repositoryFolder.AddRepositoryItem(itemCopy);
                 }

As per coding guidelines `**/*.cs`: Use `Reporter.ToLog(eLogLevel.ERROR, message)` for logging errors.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@Ginger/GingerCoreNET/Repository/SharedRepositoryOperations.cs` around lines
161 - 174, The code currently proceeds as successful when
WorkSpace.Instance.SolutionRepository.GetRepositoryFolderByPath(targetFolderPath)
returns null; update the block around RepositoryFolderBase repositoryFolder =
GetRepositoryFolderByPath(targetFolderPath) to detect null and treat it as an
error: call Reporter.ToLog(eLogLevel.ERROR, $"Failed to resolve repository
folder for path '{targetFolderPath}' while uploading item
'{itemToUpload.ExistingItem.ItemName}'") and then abort the operation by
returning a failure indicator (or setting the upload result status) instead of
adding itemCopy or marking success; ensure this change is applied where
itemToUpload, itemCopy and repositoryFolder are used so overwrite mode cannot
silently succeed when the target folder is unresolved.

Ginger/Ginger/UserControlsLib/UCListView/UcListView.xaml.cs (1)

410-414: ⚠️ Potential issue | 🟡 Minor

Handle NotifyCollectionChangedAction.Reset so folder tree does not go stale on bulk updates.

Line [410]-Line [414] skip Reset, so clear/reload operations can update the list without refreshing the folder tree.

🔧 Proposed fix

                 if (e.Action is NotifyCollectionChangedAction.Add or
                     NotifyCollectionChangedAction.Replace or
                     NotifyCollectionChangedAction.Remove or
-                    NotifyCollectionChangedAction.Move)
+                    NotifyCollectionChangedAction.Move or
+                    NotifyCollectionChangedAction.Reset)
                 {
                     OnUcListViewEvent(UcListViewEventArgs.eEventType.UpdateIndex);
 
                     // Refresh folder tree view when items are added/removed/modified
                     if (mFolderTreeRoot != null && xFolderTreeView != null)

Also applies to: 417-421

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@Ginger/Ginger/UserControlsLib/UCListView/UcListView.xaml.cs` around lines 410
- 414, The collection-changed handler currently checks e.Action for
Add/Replace/Remove/Move but omits NotifyCollectionChangedAction.Reset, causing
bulk clears/reloads to leave the folder tree stale; update the conditional(s)
that test e.Action (the branches currently listing
NotifyCollectionChangedAction.Add/Replace/Remove/Move around e.Action) to also
include NotifyCollectionChangedAction.Reset and ensure the Reset path executes
the same clear/reload/refresh logic used for the other actions so the folder
tree is updated appropriately (apply the same change to both occurrences around
the lines referencing those checks).

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Outside diff comments:
In `@Ginger/Ginger/UserControlsLib/UCListView/UcListView.xaml.cs`:
- Around line 410-414: The collection-changed handler currently checks e.Action
for Add/Replace/Remove/Move but omits NotifyCollectionChangedAction.Reset,
causing bulk clears/reloads to leave the folder tree stale; update the
conditional(s) that test e.Action (the branches currently listing
NotifyCollectionChangedAction.Add/Replace/Remove/Move around e.Action) to also
include NotifyCollectionChangedAction.Reset and ensure the Reset path executes
the same clear/reload/refresh logic used for the other actions so the folder
tree is updated appropriately (apply the same change to both occurrences around
the lines referencing those checks).

In `@Ginger/GingerCoreNET/Repository/SharedRepositoryOperations.cs`:
- Around line 161-174: The code currently proceeds as successful when
WorkSpace.Instance.SolutionRepository.GetRepositoryFolderByPath(targetFolderPath)
returns null; update the block around RepositoryFolderBase repositoryFolder =
GetRepositoryFolderByPath(targetFolderPath) to detect null and treat it as an
error: call Reporter.ToLog(eLogLevel.ERROR, $"Failed to resolve repository
folder for path '{targetFolderPath}' while uploading item
'{itemToUpload.ExistingItem.ItemName}'") and then abort the operation by
returning a failure indicator (or setting the upload result status) instead of
adding itemCopy or marking success; ensure this change is applied where
itemToUpload, itemCopy and repositoryFolder are used so overwrite mode cannot
silently succeed when the target folder is unresolved.

---

ℹ️ Review info

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ff9343d and 0d304bb.

📒 Files selected for processing (5)

• Ginger/Ginger/AutomatePageLib/AddActionMenu/SharedRepositoryLib/ActionsRepositoryPage.xaml.cs
• Ginger/Ginger/AutomatePageLib/AddActionMenu/SharedRepositoryLib/ActivitiesGroupsRepositoryPage.xaml.cs
• Ginger/Ginger/AutomatePageLib/AddActionMenu/SharedRepositoryLib/ActivitiesRepositoryPage.xaml.cs
• Ginger/Ginger/UserControlsLib/UCListView/UcListView.xaml.cs
• Ginger/GingerCoreNET/Repository/SharedRepositoryOperations.cs