Skip to content

SSH downgrade #4459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ravirk91 merged 1 commit into from
Mar 10, 2026
Merged

SSH downgrade #4459

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Ginger/GingerCore/GingerCore.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -522,7 +522,7 @@
<PackageReference Include="SkiaSharp" Version="3.116.1" />
<PackageReference Include="SkiaSharp.Views.Desktop.Common" Version="2.88.3" />
<PackageReference Include="SSH.NET">
<Version>2025.1.0</Version>
<Version>2023.0.1</Version>
</PackageReference>
Comment on lines 524 to 526

@coderabbitai coderabbitai Bot Mar 9, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Consistent SSH.NET downgrade with GingerCoreNET.csproj.

The version change is consistent with GingerCoreNET.csproj, which is appropriate since GingerCore references GingerCoreNET. However, the same concerns apply—please address the justification and security verification requested in the other file's review comment.

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@Ginger/GingerCore/GingerCore.csproj` around lines 524 - 526, The SSH.NET
PackageReference in GingerCore.csproj was downgraded to 2023.0.1—add the same
justification and security verification you added (or will add) for
GingerCoreNET.csproj: document why the downgrade is required, confirm no known
vulnerabilities for 2023.0.1 (link to CVE/advisories or Snyk/GitHub Dependabot
scan), and note compatibility/testing performed with GingerCore (mention the
PackageReference element for SSH.NET and any impacted classes that use it).
Ensure the PR/commit message or project comment includes these details so
reviewers can verify the rationale and security checks for both
GingerCore.csproj and GingerCoreNET.csproj.

<PackageReference Include="System.Collections.Concurrent">
<Version>4.3.0</Version>
Expand Down
2 changes: 1 addition & 1 deletion Ginger/GingerCoreNET/GingerCoreNET.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,7 +338,7 @@
<PackageReference Include="SharpAdbClient" Version="2.3.23" />
<PackageReference Include="SkiaSharp" Version="3.116.1" />
<PackageReference Include="SkiaSharp.NativeAssets.Linux" Version="3.116.1" />
<PackageReference Include="SSH.NET" Version="2025.1.0" />
<PackageReference Include="SSH.NET" Version="2023.0.1" />
<PackageReference Include="System.Data.DataSetExtensions" Version="4.5.0" />
<PackageReference Include="System.Data.OleDb" Version="8.0.0" />
<PackageReference Include="System.Data.SqlClient" Version="4.9.0" />
Expand Down
Loading