Refactor app/device OS filtering logic in credentials dialog

[tanushahande2003]

Rework filtering to use the currently selected OS from the ComboBox instead of the initial platform preference. Remove the PlatformMatchesInitial helper and related logic. Now, items are filtered based on the specific OS selection, improving clarity and maintainability.

Description

Type of Change

• Bug fix - [ ] New feature - [ ] Breaking change - [ ] Plugin update

Checklist

• PR description clearly describes the changes
• Target branch is correct (master for features, Releases/* for fixes)
• Latest code from target branch merged
• No commented/junk code included
• No new build warnings or errors
• All existing unit tests pass
• New unit tests added for new functionality
• Cross-platform compatibility verified (Windows/Linux/macOS)
• CI/CD pipeline passes
• Code follows project conventions (Act{Platform}{Type}, {Platform}Driver)
• Repository objects use [IsSerializedForLocalRepository] where needed
• Error handling uses Reporter.ToLog() pattern
• Documentation updated for user-facing changes
• Self-review completed and code review comments addressed

Summary by CodeRabbit

Release Notes

• Bug Fixes
  • Improved app and phone filtering in the credentials configuration dialog by simplifying filter logic for more reliable and predictable behavior.
  • Enhanced case-insensitive handling of filter options.

[codacy-production]

Not up to standards ⛔

_{TIP This summary will be updated as you push new changes. Give us feedback}

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 0ba60acc-bbb0-4b6f-bb80-83d28006a94d

📥 Commits

Reviewing files that changed from the base of the PR and between 44a50fc and 632a595.

📒 Files selected for processing (1)

• Ginger/Ginger/Drivers/DriversConfigsEditPages/UFTCredentialsDialog.xaml.cs

---

Walkthrough

The change removes platform-based gray-out logic and the PlatformMatchesInitial helper method from UFT credentials filtering, simplifying ApplyAppFilters and ApplyFilters to rely solely on combo-box selection values with case-insensitive "All" handling.

Changes

Cohort / File(s)	Summary
UFT Credentials Filtering Simplification Ginger/Ginger/Drivers/DriversConfigsEditPages/UFTCredentialsDialog.xaml.cs	Removed platform-preference gray-out logic and PlatformMatchesInitial helper method; updated filtering conditionals to handle "All" case-insensitively; renamed variables (os → appOs/deviceOs) for clarity while preserving case-insensitive equality checks against a.Type and p.Platform.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• Ginger#4472: Directly related as it introduced the platform-based graying logic and PlatformMatchesInitial helper that this PR removes.

Suggested reviewers

• ravirk91

Poem

🐰 A rabbit hops through filtering code,
Removes the gray that once exploded,
Platform logic? Gone away!
"All" now works both night and day,
Simpler filtering, cleaner road! ✨

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check	❓ Inconclusive	The PR description provides a clear summary of changes (filtering rework, PlatformMatchesInitial removal) but the checklist items remain unchecked, indicating incomplete verification of requirements.	Complete the verification checklist items, particularly confirming target branch correctness, test coverage, and cross-platform compatibility before merge.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main change: refactoring OS filtering logic in the credentials dialog to use ComboBox selection instead of platform preferences.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch bugfix/64016_UFT-lab-devices-filter

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}