Merge official to master

[ravirk91]

Description

Type of Change

• Bug fix - [ ] New feature - [ ] Breaking change - [ ] Plugin update

Checklist

• PR description clearly describes the changes
• Target branch is correct (master for features, Releases/* for fixes)
• Latest code from target branch merged
• No commented/junk code included
• No new build warnings or errors
• All existing unit tests pass
• New unit tests added for new functionality
• Cross-platform compatibility verified (Windows/Linux/macOS)
• CI/CD pipeline passes
• Code follows project conventions (Act{Platform}{Type}, {Platform}Driver)
• Repository objects use [IsSerializedForLocalRepository] where needed
• Error handling uses Reporter.ToLog() pattern
• Documentation updated for user-facing changes
• Self-review completed and code review comments addressed

Summary by CodeRabbit

Release Notes

• New Features

  • Added multi-window screenshot capture capability for driver app windows.
  • Enhanced web panel menu styling with text clamping.

• Bug Fixes

  • Improved error handling for output values grid initialization.
  • Fixed null reference protection in file system monitoring.
  • Enhanced element learning capture in inspection workflows.
  • Improved screenshot validation with retry logic for blank captures.

• Improvements

  • Better element bounds validation and dynamic updates.
  • Refined element highlighting behavior during screenshots.
  • Decoupled Java path initialization in automation tools.

• Chores

  • Updated version to 26.4.0.0.
  • Refreshed web client build artifacts.

[coderabbitai]

Walkthrough

This PR introduces multi-window screenshot capture capabilities across multiple drivers (Windows, Java, Selenium, Appium), adds element enrichment/learning to element exploration workflows, improves element bounds validation and refresh logic, simplifies platform filtering in UFT credentials dialogs, and updates web report assets alongside version bumps.

Changes

Cohort / File(s)	Summary
UI/Action Pages ActionEditPage.xaml.cs, ActSikuliEditPage.xaml.cs	Added try/catch error handling around output values grid initialization. Modified JavaPathTextBox.Init call signature by removing the CustomJavaPath argument, decoupling textbox initialization from current path value.
Element Learning & Enrichment PomAllElementsPage.xaml.cs, LiveSpyPage.xaml.cs	Updated to capture return value from LearnElementInfoDetails into learnedElement; when non-null, replaces mSpyElement with enriched instance and reapplies WindowExplorer reference to ensure subsequent operations use learned data.
Window Explorer & Highlighting WindowExplorerPage.xaml.cs	Added bounds refresh/validation logic that calls UpdateElementInfoFields when element width/height are invalid; introduced highlightInApp parameter to DrawElementRectangleAsync to prevent in-app highlighting during screenshot-derived rectangle drawing; added debug logging for bounds validation failures.
UFT Credentials Dialog UFTCredentialsDialog.xaml, UFTCredentialsDialog.xaml.cs	Removed platform "grayed out" state handling and PlatformMatchesInitial helper; simplified OS filtering to case-insensitive "All" checks; added collapsed hint TextBlock for credential completion indication; adjusted XAML nesting structure.
Windows & Java Driver Screenshots WindowsDriver.cs, JavaDriver.cs, UIAComWrapperHelper.cs	Enhanced screenshot capture to support AllAvailableWindows mode by iterating driver app windows, capturing each window and associated dialogs separately; added null checks and early-return logic for populated screenshot collections; refactored window capture flow.
Selenium Driver Screenshot & Handling SeleniumDriver.cs	Implemented multi-window screenshot iteration with switch/wait/capture cycle; added blank screenshot detection heuristic and retry logic with full-page fallback; wrapped screenshot retrieval in try/catch; added AllAvailableWindows window-switching behavior.
Web Action Handler ActScreenShotHandler.cs	Added PrepareTabForScreenshotAsync to invoke BringToFrontAsync() on Playwright tabs before screenshot/title retrieval; updated active window detection to support zero browser windows fallback; prepared each tab individually during all-windows capture.
Appium/Mobile Driver GenericAppiumDriver.cs	Updated EnsureDeviceBounds to guard short-circuit and use null-safe property lookup; added element object preservation logic for non-locator resolution paths; enhanced bounds parsing to compute width/height from parsed rectangle coordinates.
Version & Project Configuration GingerCoreCommon.csproj	Updated AssemblyVersion, FileVersion, and NuGet Version from 26.3.0.0/2026.3.0.2 to 26.4.0.0/2026.4.0.0.
Web Report Assets & Configuration GingerCoreNET.csproj, index.html, theme-report.css, _dashboard.scss	Added new web client build artifacts (main.*.js, polyfills.*.js, runtime.*.js, scripts.*.js, styles.*.css) to project with CopyToOutputDirectory; updated asset hash references in HTML; added menu item text styling with 2-line clamping; updated comment label in SCSS.
Bundled Web Assets polyfills.ab6619d5cdfdf12c.js, polyfills.af067c955617ac11.js, runtime.9298f7d16182d7dd.js	Removed obsolete polyfills chunk and added new one with Zone.js runtime and core-js polyfills; updated runtime module-id mapping from {666:0} to {121:0}.
Database & Repository ExportToExcelConfig.cs, RepositoryFolder.cs, AppsListPage.xaml.cs	Removed whitespace in method signature; added null guard for mSubFoldersCache before .Any() call in deleted event handler; added UTF-8 BOM marker to AppsListPage.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~85 minutes

Possibly related PRs

• Improve mobile element highlighting and rectangle accuracy #4480 — Overlapping multi-window/all-available-windows screenshot logic and element enrichment changes across PomAllElementsPage, LiveSpyPage, WindowExplorerPage, and GenericAppiumDriver.
• Refactor app/device OS filtering logic in credentials dialog #4483 — Identical refactor to remove platform "grayed out" state logic and PlatformMatchesInitial helper from UFTCredentialsDialog.xaml.cs with case-insensitive OS filtering.
• Adding take a screenshot func for images of screen elements in mobile #4222 — Related changes to GenericAppiumDriver bounds extraction and width/height computation used by element operations.

Suggested reviewers

• Maheshkale447

Poem

🐰 With windows wide and bounds now bright,
Element enrichment takes flight!
Screenshots bloom in every frame,
Multi-window capture—no screenshot shame!
Appium bounds dance, bounds refresh tight,
The spying explorer now sees the light! ✨

🚥 Pre-merge checks | ❌ 3

❌ Failed checks (2 warnings, 1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The pull request description contains only the empty template with unchecked checkboxes and no actual functional description of the changes being merged.	Fill in the Description section with a summary of the major changes (Android TV support, security updates, driver refactors, etc.) and check appropriate Type of Change boxes to reflect the scope of modifications.
Docstring Coverage	⚠️ Warning	Docstring coverage is 3.37% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check	❓ Inconclusive	The title "Merge official to master" is extremely vague and does not meaningfully convey the content of this large, multi-faceted pull request that includes platform support, security updates, driver refactors, and numerous bug fixes.	Provide a more specific title that highlights the primary changes, such as "Add Android TV platform support and refactor screenshot/window capture logic" or "Merge official: add Android TV support, update dependencies, improve driver robustness".

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch Merge-official-to-master

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 17

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (5)

Ginger/GingerCoreCommon/DataBaseLib/ExportToExcelConfig.cs (3)

155-156: ⚠️ Potential issue | 🔴 Critical

Fix logic error: leading " AND " when first items are skipped.

The code uses the loop index i to determine when to add " AND " separators. However, when the first item(s) are skipped due to invalid TableColumn or RowValue, the first valid item will have i > 0, causing a leading " AND " to be added:

Example:

• i=0: invalid item (empty TableColumn), skipped
• i=1: valid item, but i > 0 → whereClause = " AND column = 'value'" ❌

This produces a malformed where clause.

🔧 Proposed fix using a flag to track the first valid item

         string whereClause = "";
+        bool isFirstPredicate = true;
 
         // Build WHERE clause (Ginger format)
         for (int i = 0; i < whereConditionList.Count; i++)
         {
 
             var item = whereConditionList[i];
 
 
             // PR change: skip invalid items
             if (string.IsNullOrEmpty(item.TableColumn) || string.IsNullOrEmpty(item.RowValue))
                 continue;
 
             string predicate = "";
             switch (item.Opertor)
             {
                 case "Equals":
                     predicate = $"{item.TableColumn} = \"{item.RowValue}\"";
                     break;
                 case "NotEquals":
                     predicate = $"{item.TableColumn} <> \"{item.RowValue}\"";
                     break;
                 case "Contains":
                     predicate = $"{item.TableColumn} Like \"%{item.RowValue}%\"";
                     break;
                 case "NotContains":
                     predicate = $"{item.TableColumn} Not Like \"%{item.RowValue}%\"";
                     break;
                 case "StartsWith":
                     predicate = $"{item.TableColumn} Like \"{item.RowValue}%\"";
                     break;
                 case "EndsWith":
                     predicate = $"{item.TableColumn} Like \"%{item.RowValue}\"";
                     break;
                 case "NotStartsWith":
                     predicate = $"{item.TableColumn} Not Like \"{item.RowValue}%\"";
                     break;
                 case "NotEndsWith":
                     predicate = $"{item.TableColumn} Not Like \"%{item.RowValue}\"";
                     break;
 
             }
-            if (i > 0)
+            if (!isFirstPredicate)
                 whereClause += " AND ";
+            else
+                isFirstPredicate = false;
             whereClause += predicate;
         }

Also applies to: 187-189

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@Ginger/GingerCoreCommon/DataBaseLib/ExportToExcelConfig.cs` around lines 155
- 156, The where-clause builder incorrectly uses the loop index `i` to decide
when to prepend " AND ", which yields a leading " AND " if earlier items were
skipped; in ExportToExcelConfig.cs (in the method that constructs the WHERE
clause inside the loop containing the if (string.IsNullOrEmpty(item.TableColumn)
|| string.IsNullOrEmpty(item.RowValue)) continue;), replace the i-based check
with a boolean flag (e.g., firstClauseAdded) or a counter that tracks how many
valid clauses have been appended and only prepend " AND " when that flag/counter
indicates a previous valid clause exists; apply the same change to the other
similar block referenced around lines 187-189 so both places use the
flag/counter instead of i to determine adding " AND ".

---

155-156: ⚠️ Potential issue | 🟡 Minor

Add error logging when skipping invalid where condition items.

The code silently skips where condition items with missing TableColumn or RowValue. This can hide configuration errors or data integrity issues, making debugging difficult.

Consider logging these skipped items to help diagnose issues.

📝 Proposed fix to add logging

             // PR change: skip invalid items
             if (string.IsNullOrEmpty(item.TableColumn) || string.IsNullOrEmpty(item.RowValue))
+            {
+                Reporter.ToLog(eLogLevel.ERROR, $"Skipping invalid where condition item: TableColumn='{item.TableColumn}', RowValue='{item.RowValue}'");
                 continue;
+            }

As per coding guidelines, use Reporter.ToLog(eLogLevel.ERROR, message) for logging errors in **/*.cs files.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@Ginger/GingerCoreCommon/DataBaseLib/ExportToExcelConfig.cs` around lines 155
- 156, The loop that currently silently continues when a where-condition item
has null/empty TableColumn or RowValue should log an error before skipping;
inside the block that checks if (string.IsNullOrEmpty(item.TableColumn) ||
string.IsNullOrEmpty(item.RowValue)) add a Reporter.ToLog(eLogLevel.ERROR, ...)
call that includes identifying details (e.g., item.TableColumn, item.RowValue,
and if available an index or item.ToString()) and a short message indicating the
item was skipped due to invalid where condition; ensure this change is made in
the ExportToExcelConfig code path that processes the where-condition items so
invalid config/data is recorded.

---

159-186: ⚠️ Potential issue | 🟠 Major

Add default case to handle unrecognized operators.

The switch statement has no default case. If item.Opertor doesn't match any of the defined cases, predicate remains an empty string and still gets appended to the WHERE clause (line 190), producing malformed output such as:

• "col1 = 'val1' AND AND col2 = 'val2'" (double AND separator)
• "col1 = 'val1' AND " (trailing AND)

Add a default case to handle or log unrecognized operators.

🛡️ Proposed fix with default case and logging

             switch (item.Opertor)
             {
                 case "Equals":
                     predicate = $"{item.TableColumn} = \"{item.RowValue}\"";
                     break;
                 case "NotEquals":
                     predicate = $"{item.TableColumn} <> \"{item.RowValue}\"";
                     break;
                 case "Contains":
                     predicate = $"{item.TableColumn} Like \"%{item.RowValue}%\"";
                     break;
                 case "NotContains":
                     predicate = $"{item.TableColumn} Not Like \"%{item.RowValue}%\"";
                     break;
                 case "StartsWith":
                     predicate = $"{item.TableColumn} Like \"{item.RowValue}%\"";
                     break;
                 case "EndsWith":
                     predicate = $"{item.TableColumn} Like \"%{item.RowValue}\"";
                     break;
                 case "NotStartsWith":
                     predicate = $"{item.TableColumn} Not Like \"{item.RowValue}%\"";
                     break;
                 case "NotEndsWith":
                     predicate = $"{item.TableColumn} Not Like \"%{item.RowValue}\"";
                     break;
+                default:
+                    Reporter.ToLog(eLogLevel.ERROR, $"Unrecognized operator '{item.Opertor}' for column '{item.TableColumn}'. Skipping condition.");
+                    continue;  // Skip this item
             }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@Ginger/GingerCoreCommon/DataBaseLib/ExportToExcelConfig.cs` around lines 159
- 186, The switch on item.Opertor in ExportToExcelConfig.cs can leave predicate
empty for unknown operators which later gets appended into the WHERE clause; add
a default case that logs or records the unrecognized operator (including
item.Opertor and item.TableColumn) and sets predicate to null/empty in a way
that the calling code will skip adding it, and additionally guard the code that
appends predicate to the WHERE clause to only append when predicate is non-empty
(check predicate != null/""), so you never produce stray "AND" or trailing
separators.

Ginger/GingerCore/Actions/UIAutomation/UIAComWrapperHelper.cs (1)

4858-4891: ⚠️ Potential issue | 🟠 Major

Don’t let one bad window abort the entire multi-window capture.

Any exception from one GetAppWindowAsBitmap(aw) / GetAppDialogAsBitmap(aw) currently exits the whole method, so later windows are never captured. This new path should catch per window and continue.

Proposed change

             if (act.WindowsToCapture == Act.eWindowsToCapture.AllAvailableWindows)
             {
                 List<AppWindow> windows = GetListOfDriverAppWindows();
                 foreach (AppWindow aw in windows)
                 {
-                    using (Bitmap bmp = GetAppWindowAsBitmap(aw))
+                    try
                     {
-                        if (bmp != null)
+                        using (Bitmap bmp = GetAppWindowAsBitmap(aw))
                         {
-                            act.AddScreenShot(bmp);
+                            if (bmp != null)
+                            {
+                                act.AddScreenShot(bmp);
+                            }
                         }
-                    }
-                    List<Bitmap> dialogs = GetAppDialogAsBitmap(aw);
-                    foreach (Bitmap dialogBmp in dialogs)
-                    {
-                        act.AddScreenShot(dialogBmp);
-                    }
-                    dialogs.Clear();
+
+                        List<Bitmap> dialogs = GetAppDialogAsBitmap(aw);
+                        foreach (Bitmap dialogBmp in dialogs)
+                        {
+                            act.AddScreenShot(dialogBmp);
+                        }
+                        dialogs.Clear();
+                    }
+                    catch (Exception ex)
+                    {
+                        Reporter.ToLog(eLogLevel.ERROR, "Failed to capture one application window screenshot", ex);
+                    }
                 }
             }

As per coding guidelines, **/*.cs: Use Reporter.ToLog(eLogLevel.ERROR, message) for logging errors.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@Ginger/GingerCore/Actions/UIAutomation/UIAComWrapperHelper.cs` around lines
4858 - 4891, The current try around the entire multi-window capture aborts on
any window error; change it so each AppWindow is processed inside its own
try/catch: call GetListOfDriverAppWindows(), then for each AppWindow aw wrap the
GetAppWindowAsBitmap(aw) usage and the GetAppDialogAsBitmap(aw) loop in a
per-window try/catch so a failure for one aw does not stop others; on per-window
exceptions log using Reporter.ToLog(eLogLevel.ERROR, "Failed to capture window "
+ aw?.Title + " or its dialogs: " + ex.Message) (include exception info as
appropriate) and continue to the next window; also ensure null checks before
AddScreenShot and remove the outer broad catch or keep it for fallback but still
use ERROR level for errors.

Ginger/GingerCoreNET/Drivers/CoreDrivers/Web/Selenium/SeleniumDriver.cs (1)

505-511: ⚠️ Potential issue | 🟠 Major

Avoid calling CloseDriver() from the finalizer.

CloseDriver() performs substantial managed cleanup including event unsubscription, logging via Reporter.ToLog(), and blocking async operations (StopNetworkLog().GetAwaiter().GetResult()) on the GC finalizer thread. This violates C# best practices and risks deadlocks and thread safety issues. Implement IDisposable with cleanup in Dispose() and reserve the finalizer, if needed, for unmanaged resources only.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@Ginger/GingerCoreNET/Drivers/CoreDrivers/Web/Selenium/SeleniumDriver.cs`
around lines 505 - 511, The finalizer ~SeleniumDriver() calls CloseDriver()
which performs managed cleanup (event unsubscription, Reporter.ToLog(), and
StopNetworkLog().GetAwaiter().GetResult()) and must be moved to IDisposable;
implement IDisposable on SeleniumDriver, add a Dispose() method that calls a
protected Dispose(bool disposing) where if disposing == true you call
CloseDriver() (and release managed resources like Driver, unsubscribe events,
stop network logs asynchronously from a safe context), call
GC.SuppressFinalize(this) in Dispose(), and either remove the finalizer or
change it to call Dispose(false) only if there are unmanaged resources; also
remove any blocking async waits from finalizer code and ensure StopNetworkLog()
is awaited/handled only during Dispose().

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@Ginger/Ginger/Actions/ActionEditPage.xaml.cs`:
- Around line 529-536: The catch around SetActReturnValuesGrid currently
swallows NullReferenceException and logs with the wrong signature; change the
failure handling so the UI does not remain partially initialized: in the catch
for errors from SetActReturnValuesGrid, call Reporter.ToLog(eLogLevel.ERROR,
"Failed to initialize Output Values grid") (use the two-parameter signature
required by the repo) and then explicitly disable or exit the output-values UI
path (for example disable the tab/control and return from the initializer or
rethrow) so no further UI flow for output values runs after the failure; keep
the fix localized to the SetActReturnValuesGrid call and its surrounding catch
block.

In
`@Ginger/Ginger/AutomatePageLib/AddActionMenu/WindowExplorer/Common/WindowExplorerPage.xaml.cs`:
- Around line 1493-1510: The DrawElementRectangleAsync path currently calls
mWindowExplorerDriver.UpdateElementInfoFields(clickedElementInfo) but treats it
as synchronous, so the subsequent Width/Height check can still see stale zeroes;
change this to wait for the refresh to complete by either (A) making
UpdateElementInfoFields return a Task and awaiting it in
DrawElementRectangleAsync, or (B) if you cannot change that method signature,
implement a short polling loop after calling UpdateElementInfoFields that checks
clickedElementInfo.Width/Height with small delays and a reasonable timeout
(e.g., a few hundred ms) before deciding to skip drawing; reference
DrawElementRectangleAsync, UpdateElementInfoFields, clickedElementInfo and
mWindowExplorerDriver to locate where to add the await or polling.

In `@Ginger/Ginger/Drivers/DriversConfigsEditPages/UFTCredentialsDialog.xaml`:
- Around line 40-43: The hint text in xCredentialsHintTextBlock promises
validation for “all credential fields” but the dialog only validates Client Id,
Client Secret, and Tenant Id; update the behavior by either (A) extending the
validation routine that toggles xCredentialsHintTextBlock to also check the
Server URL input control (add Server URL to the same validation path used for
ClientId/ClientSecret/TenantId), or (B) narrow the hint copy in the TextBlock
Run to explicitly list only the fields actually validated (e.g., “Please fill
Client Id, Client Secret, and Tenant Id.”) so the message matches the
implemented validation; reference xCredentialsHintTextBlock and the dialog’s
credential-validation method/handler when making the change.

In `@Ginger/Ginger/Drivers/DriversConfigsEditPages/UFTCredentialsDialog.xaml.cs`:
- Around line 1049-1051: The filter currently uses exact equality between
xOsTypeCombo.SelectedItem and UftPhoneViewModel.Platform which splits families
like "Android TV" or versioned names; implement NormalizePlatformFamily(string)
to trim/lowercase and map any value containing "android" -> "android",
containing "ios" -> "ios", else return the normalized value, add
MatchesPlatformFamily(string platform, string filter) that compares
NormalizePlatformFamily(platform) and NormalizePlatformFamily(filter) with
OrdinalIgnoreCase, and replace the string.Equals call in the filtering block
(and any similar exact-equality platform checks) to use MatchesPlatformFamily so
devices are grouped by platform family rather than exact payload text.

In `@Ginger/GingerCore/Actions/UIAutomation/UIAComWrapperHelper.cs`:
- Around line 4862-4878: The loop over GetListOfDriverAppWindows is capturing
non-current windows but WindowToBitmap (and its helpers) still operate on
CurrentWindow; change the flow so the window element being captured (aw or
dialog element returned by GetAppDialogAsBitmap) is prepared and painted before
printing: call HandlePaintWindow(aw) (or equivalent) and
WinAPIAutomation.ShowWindow(aw) instead of operating on CurrentWindow, add a
short Thread.Sleep to allow repaint, then re-read
tempWindow.Current.BoundingRectangle and if width/height are zero call
ShowWindow(aw) again before creating the Bitmap and calling
PrintWindow(tempWindow.Current.NativeWindowHandle). Ensure WindowToBitmap
accepts and uses the passed UIA element (tempWindow) throughout rather than
referencing CurrentWindow.

In `@Ginger/GingerCore/Drivers/WindowsLib/WindowsDriver.cs`:
- Around line 244-245: The foreach over AppWindow objects can throw if
mUIAutomationHelper.GetListOfDriverAppWindows() returns null; update the code in
WindowsDriver.cs to guard the iteration by obtaining the list into a local
(e.g., list) and then either check for null before the foreach or replace it
with a null-coalescing fallback (e.g., use an empty collection via ?? or
Enumerable.Empty<AppWindow>()) so the loop over AppWindow aw will never receive
a null reference; keep references to mUIAutomationHelper and
GetListOfDriverAppWindows() unchanged otherwise.
- Around line 254-259: The dialog bitmaps returned by
mUIAutomationHelper.GetAppDialogAsBitmap are not disposed, causing GDI leaks;
after calling act.AddScreenShot for each Bitmap in bList (the loop that iterates
tempbmp), explicitly dispose each Bitmap (e.g., call tempbmp.Dispose() or wrap
each in a using) before clearing the list so the unmanaged resources are
released; ensure this change is applied in the same block where bList is
iterated (the loop that calls act.AddScreenShot) and keep bList.Clear() only for
clearing references after disposal.

In `@Ginger/GingerCoreCommon/DataBaseLib/ExportToExcelConfig.cs`:
- Line 133: The parameter list in the method signature CreateQueryWithWhereList
has a missing space after the first comma; update the signature so there's a
space between "mColumnList," and "ObservableList<WhereConditionItem>
whereConditionList" to match C# conventions and ensure consistent formatting
across the codebase (adjust only the parameter spacing in the
CreateQueryWithWhereList declaration).

In `@Ginger/GingerCoreCommon/GingerCoreCommon.csproj`:
- Line 11: Update the TargetFramework entry in GingerCoreCommon's project file:
replace the existing <TargetFramework>net10.0</TargetFramework> with the
Windows-targeted framework identifier
<TargetFramework>net10.0-windows10.0.17763.0</TargetFramework> so it matches the
pattern used by Ginger.csproj, GingerCoreTest.csproj and GingerTest.csproj;
ensure the change is applied in the GingerCoreCommon.csproj project definition
and run a build to verify no further framework-specific adjustments are needed.

In
`@Ginger/GingerCoreNET/Drivers/CoreDrivers/Mobile/Appium/GenericAppiumDriver.cs`:
- Around line 1804-1814: The code currently prefers ei.Properties["bounds"] over
the live IWebElement value; change the logic in the method (where ei and
IWebElement we are used) to prefer we.GetAttribute("bounds") when we is non-null
(i.e., call we.GetAttribute first and use it if non-empty, falling back to
ei.Properties lookup only if the live attribute is null/empty), and when writing
the bounds back into ei.Properties later, update the existing property (find by
Name equals "bounds" case-insensitive and set its Value) instead of appending a
new entry so you overwrite stale snapshots rather than adding duplicates.

In
`@Ginger/GingerCoreNET/Drivers/CoreDrivers/Web/ActionHandlers/ActScreenShotHandler.cs`:
- Around line 152-159: The full-page handlers don't prepare the tab before
capturing, so update HandleFullPageOperationAsync and
HandleFullPageWithURLAndTimestampOperationAsync to call and await
PrepareTabForScreenshotAsync(CurrentTab) (which will invoke
PlaywrightBrowserTab.BringToFrontAsync when applicable) before accessing
CurrentTab for capture; ensure the await is used so the tab is actually brought
to front for Playwright captures.

In `@Ginger/GingerCoreNET/Drivers/CoreDrivers/Web/Selenium/SeleniumDriver.cs`:
- Around line 2044-2057: The loop that iterates open windows (when
act.WindowsToCapture == Act.eWindowsToCapture.AllAvailableWindows) sets
currentWindow = Driver.CurrentWindowHandle but does not guarantee restoring it
if an exception occurs; wrap the window-switching and AddCurrentScreenShot calls
in a try/finally so that after iterating (or if any SwitchTo().Window(winHandle)
or AddCurrentScreenShot(act) throws) you always call
Driver.SwitchTo().Window(currentWindow) in the finally block to restore focus to
the original window; update the block around Driver.CurrentWindowHandle,
Driver.WindowHandles, the foreach over winHandle, and AddCurrentScreenShot(act)
accordingly.
- Around line 2059-2065: The flag
TakeOnlyActiveFrameOrWindowScreenShotInCaseOfFailure is short-circuiting the
FullPageWithUrlAndTimestamp branch; update the conditional so the timestamped
desktop-capture branch (TakeFullPageWithDesktopScreenScreenShot) is reachable.
Either move the TakeOnlyActiveFrameOrWindowScreenShotInCaseOfFailure check below
the FullPageWithUrlAndTimestamp branch, or change its condition to only apply
when act.WindowsToCapture is One of the active-window modes (e.g.,
Act.eWindowsToCapture.OnlyActiveWindow or
Act.eWindowsToCapture.AllAvailableWindows), leaving
Act.eWindowsToCapture.FullPageWithUrlAndTimestamp to call
TakeFullPageWithDesktopScreenScreenShot(act) as intended.
- Around line 3689-3699: The branch handling attribute assignment must fail the
action and log an ERROR when input is malformed or when the target element is
missing: validate the result of act.GetInputParamCalculatedValue("Value") split
(vals) and if vals.Length != 2 call Reporter.ToLog(eLogLevel.ERROR, ...) and
return/fail the action, then call LocateElement(act) and check for null (or
handle exceptions from LocateElement) before invoking
((IJavaScriptExecutor)Driver).ExecuteScript; update the log level from DEBUG to
ERROR for bad input and ensure this code path uses the same failure/reporting
behavior as GenElementHandler for missing elements.
- Around line 5865-5868: ProcessSvgChildElements is calling GetElementTypeEnum
with TypeAtt = nameof(eElementType.Svg) but GetElementTypeEnum/GetElementType
only remaps a small set of SVG tags so many SVG children (text, image, defs,
clipPath, mask and gradient nodes) fall through to non-SVG enums and get
misclassified; update the element-type mapping inside
GetElementTypeEnum/GetElementType to explicitly recognize and return
eElementType.Svg (or the appropriate SVG-specific enum) for the missing tags
(text, image, defs, clipPath, mask, linearGradient, radialGradient, etc.), and
ensure GetElementTypeEnum still respects the passed TypeAtt parameter so
ShouldLearnElement receives the correct Item2 for SVG children (apply same
changes where GetElementTypeEnum is used around the other occurrence noted).

In
`@Ginger/GingerCoreNET/Reports/Ginger-Web-Client/assets/sass/layout/_dashboard.scss`:
- Line 43: The CSS comment `/*Timeline*/` violates the comment-whitespace-inside
rule; replace that exact token with `/* Timeline */` in _dashboard.scss (update
the comment text `/*Timeline*/` to include single spaces after the opening and
before the closing `/* */`) and re-run stylelint to confirm the violation is
resolved.

In
`@Ginger/GingerCoreNET/Reports/Ginger-Web-Client/polyfills.af067c955617ac11.js`:
- Line 1: Remove the stale pre-built polyfills file reference by deleting
polyfills.ab6619d5cdfdf12c.js from the repository and removing its
Include/ItemGroup entry that uses CopyToOutputDirectory=Always from the project
file (the .csproj entry that references the old polyfills). Then add a short
README.md to the Ginger-Web-Client folder documenting the source/version/hash of
the shipped pre-built asset (e.g., that polyfills.af067c955617ac11.js is a
pre-built bundle, its upstream build/source and version, and instructions on how
to rebuild/update it), and commit the deletion and the documentation together so
future maintainers can find and update the polyfills asset.

---

Outside diff comments:
In `@Ginger/GingerCore/Actions/UIAutomation/UIAComWrapperHelper.cs`:
- Around line 4858-4891: The current try around the entire multi-window capture
aborts on any window error; change it so each AppWindow is processed inside its
own try/catch: call GetListOfDriverAppWindows(), then for each AppWindow aw wrap
the GetAppWindowAsBitmap(aw) usage and the GetAppDialogAsBitmap(aw) loop in a
per-window try/catch so a failure for one aw does not stop others; on per-window
exceptions log using Reporter.ToLog(eLogLevel.ERROR, "Failed to capture window "
+ aw?.Title + " or its dialogs: " + ex.Message) (include exception info as
appropriate) and continue to the next window; also ensure null checks before
AddScreenShot and remove the outer broad catch or keep it for fallback but still
use ERROR level for errors.

In `@Ginger/GingerCoreCommon/DataBaseLib/ExportToExcelConfig.cs`:
- Around line 155-156: The where-clause builder incorrectly uses the loop index
`i` to decide when to prepend " AND ", which yields a leading " AND " if earlier
items were skipped; in ExportToExcelConfig.cs (in the method that constructs the
WHERE clause inside the loop containing the if
(string.IsNullOrEmpty(item.TableColumn) || string.IsNullOrEmpty(item.RowValue))
continue;), replace the i-based check with a boolean flag (e.g.,
firstClauseAdded) or a counter that tracks how many valid clauses have been
appended and only prepend " AND " when that flag/counter indicates a previous
valid clause exists; apply the same change to the other similar block referenced
around lines 187-189 so both places use the flag/counter instead of i to
determine adding " AND ".
- Around line 155-156: The loop that currently silently continues when a
where-condition item has null/empty TableColumn or RowValue should log an error
before skipping; inside the block that checks if
(string.IsNullOrEmpty(item.TableColumn) || string.IsNullOrEmpty(item.RowValue))
add a Reporter.ToLog(eLogLevel.ERROR, ...) call that includes identifying
details (e.g., item.TableColumn, item.RowValue, and if available an index or
item.ToString()) and a short message indicating the item was skipped due to
invalid where condition; ensure this change is made in the ExportToExcelConfig
code path that processes the where-condition items so invalid config/data is
recorded.
- Around line 159-186: The switch on item.Opertor in ExportToExcelConfig.cs can
leave predicate empty for unknown operators which later gets appended into the
WHERE clause; add a default case that logs or records the unrecognized operator
(including item.Opertor and item.TableColumn) and sets predicate to null/empty
in a way that the calling code will skip adding it, and additionally guard the
code that appends predicate to the WHERE clause to only append when predicate is
non-empty (check predicate != null/""), so you never produce stray "AND" or
trailing separators.

In `@Ginger/GingerCoreNET/Drivers/CoreDrivers/Web/Selenium/SeleniumDriver.cs`:
- Around line 505-511: The finalizer ~SeleniumDriver() calls CloseDriver() which
performs managed cleanup (event unsubscription, Reporter.ToLog(), and
StopNetworkLog().GetAwaiter().GetResult()) and must be moved to IDisposable;
implement IDisposable on SeleniumDriver, add a Dispose() method that calls a
protected Dispose(bool disposing) where if disposing == true you call
CloseDriver() (and release managed resources like Driver, unsubscribe events,
stop network logs asynchronously from a safe context), call
GC.SuppressFinalize(this) in Dispose(), and either remove the finalizer or
change it to call Dispose(false) only if there are unmanaged resources; also
remove any blocking async waits from finalizer code and ensure StopNetworkLog()
is awaited/handled only during Dispose().

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 9b065b41-1735-4409-9bdf-8443b2eddac5

📥 Commits

Reviewing files that changed from the base of the PR and between 024a94e and f95223c.

⛔ Files ignored due to path filters (2)

• Ginger/GingerCoreNET/Reports/Ginger-Web-Client/assets/layout/images/amdocs.png is excluded by !**/*.png, !**/*.png
• Ginger/GingerCoreNET/Reports/Ginger-Web-Client/assets/layout/images/amdocs_old1.png is excluded by !**/*.png, !**/*.png

📒 Files selected for processing (29)

• Ginger/Ginger/Actions/ActionEditPage.xaml.cs
• Ginger/Ginger/Actions/ActionEditPages/ActSikuliEditPage.xaml.cs
• Ginger/Ginger/ApplicationModelsLib/POMModels/PomAllElementsPage.xaml.cs
• Ginger/Ginger/AutomatePageLib/AddActionMenu/LiveSpy/LiveSpyPage.xaml.cs
• Ginger/Ginger/AutomatePageLib/AddActionMenu/WindowExplorer/Common/WindowExplorerPage.xaml.cs
• Ginger/Ginger/Drivers/DriversConfigsEditPages/UFTCredentialsDialog.xaml
• Ginger/Ginger/Drivers/DriversConfigsEditPages/UFTCredentialsDialog.xaml.cs
• Ginger/Ginger/Environments/AppsListPage.xaml.cs
• Ginger/GingerCore/Actions/UIAutomation/UIAComWrapperHelper.cs
• Ginger/GingerCore/Drivers/JavaDriverLib/JavaDriver.cs
• Ginger/GingerCore/Drivers/WindowsLib/WindowsDriver.cs
• Ginger/GingerCoreCommon/DataBaseLib/ExportToExcelConfig.cs
• Ginger/GingerCoreCommon/GingerCoreCommon.csproj
• Ginger/GingerCoreCommon/Repository/RepositoryFolder.cs
• Ginger/GingerCoreNET/Drivers/CoreDrivers/Mobile/Appium/GenericAppiumDriver.cs
• Ginger/GingerCoreNET/Drivers/CoreDrivers/Web/ActionHandlers/ActScreenShotHandler.cs
• Ginger/GingerCoreNET/Drivers/CoreDrivers/Web/Selenium/SeleniumDriver.cs
• Ginger/GingerCoreNET/GingerCoreNET.csproj
• Ginger/GingerCoreNET/Reports/Ginger-Web-Client/assets/artifacts/test.txt
• Ginger/GingerCoreNET/Reports/Ginger-Web-Client/assets/sass/layout/_dashboard.scss
• Ginger/GingerCoreNET/Reports/Ginger-Web-Client/assets/theme/theme-report.css
• Ginger/GingerCoreNET/Reports/Ginger-Web-Client/index.html
• Ginger/GingerCoreNET/Reports/Ginger-Web-Client/main.50dca4a1d8ae08b9.js
• Ginger/GingerCoreNET/Reports/Ginger-Web-Client/main.894d579b9b86a2c7.js
• Ginger/GingerCoreNET/Reports/Ginger-Web-Client/polyfills.ab6619d5cdfdf12c.js
• Ginger/GingerCoreNET/Reports/Ginger-Web-Client/polyfills.af067c955617ac11.js
• Ginger/GingerCoreNET/Reports/Ginger-Web-Client/runtime.9298f7d16182d7dd.js
• Ginger/GingerCoreNET/Reports/Ginger-Web-Client/scripts.510ef496b81fd3ec.js
• Ginger/GingerCoreNET/Reports/Ginger-Web-Client/styles.a4dfb05f8a7c3211.css

💤 Files with no reviewable changes (1)

• Ginger/GingerCoreNET/Reports/Ginger-Web-Client/polyfills.ab6619d5cdfdf12c.js

[coderabbitai]

⚠️ Potential issue | 🟠 Major

Avoid partial initialization after failure, and use the error-log signature required by repo guidelines.

At Line 533, catching NullReferenceException and continuing can leave this tab half-initialized. Handle the failure path explicitly (disable/exit) so later UI flow doesn’t proceed in an invalid state. Also Line 535 should follow the project logging rule format.

Proposed fix

             try
             {
                 SetActReturnValuesGrid();
             }
             catch (NullReferenceException ex)
             {
-                Reporter.ToLog(eLogLevel.ERROR, "Failed to initialize Output Values grid", ex);
+                Reporter.ToLog(eLogLevel.ERROR, $"Failed to initialize Output Values grid. {ex}");
+                Reporter.ToUser(eUserMsgKey.StaticErrorMessage, "Failed to load Output Values grid. Please reopen the action and check logs.");
+                xOutputValuesGrid.IsEnabled = false;
+                return;
             }

As per coding guidelines: **/*.cs: Use Reporter.ToLog(eLogLevel.ERROR, message) for logging errors.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@Ginger/Ginger/Actions/ActionEditPage.xaml.cs` around lines 529 - 536, The
catch around SetActReturnValuesGrid currently swallows NullReferenceException
and logs with the wrong signature; change the failure handling so the UI does
not remain partially initialized: in the catch for errors from
SetActReturnValuesGrid, call Reporter.ToLog(eLogLevel.ERROR, "Failed to
initialize Output Values grid") (use the two-parameter signature required by the
repo) and then explicitly disable or exit the output-values UI path (for example
disable the tab/control and return from the initializer or rethrow) so no
further UI flow for output values runs after the failure; keep the fix localized
to the SetActReturnValuesGrid call and its surrounding catch block.

[coderabbitai]

⚠️ Potential issue | 🟠 Major

Don't treat UpdateElementInfoFields() as synchronous here.

On Playwright, UpdateElementInfoFields() updates the same ElementInfo from a background Task.Run, so the immediate Width/Height recheck can still see stale zeroes and return early. That makes the new “refresh bounds then draw” path intermittently skip the rectangle for elements that depend on the refresh.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In
`@Ginger/Ginger/AutomatePageLib/AddActionMenu/WindowExplorer/Common/WindowExplorerPage.xaml.cs`
around lines 1493 - 1510, The DrawElementRectangleAsync path currently calls
mWindowExplorerDriver.UpdateElementInfoFields(clickedElementInfo) but treats it
as synchronous, so the subsequent Width/Height check can still see stale zeroes;
change this to wait for the refresh to complete by either (A) making
UpdateElementInfoFields return a Task and awaiting it in
DrawElementRectangleAsync, or (B) if you cannot change that method signature,
implement a short polling loop after calling UpdateElementInfoFields that checks
clickedElementInfo.Width/Height with small delays and a reasonable timeout
(e.g., a few hundred ms) before deciding to skip drawing; reference
DrawElementRectangleAsync, UpdateElementInfoFields, clickedElementInfo and
mWindowExplorerDriver to locate where to add the await or polling.

[coderabbitai]

⚠️ Potential issue | 🟠 Major

Hint text promises validation we do not perform.

This copy says “all credential fields”, but the dialog only checks Client Id, Client Secret, and Tenant Id. With Server URL empty, this hint can disappear and the fetch still fails later. Either include Server URL in the same validation path or narrow the message to the fields that are actually enforced.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@Ginger/Ginger/Drivers/DriversConfigsEditPages/UFTCredentialsDialog.xaml`
around lines 40 - 43, The hint text in xCredentialsHintTextBlock promises
validation for “all credential fields” but the dialog only validates Client Id,
Client Secret, and Tenant Id; update the behavior by either (A) extending the
validation routine that toggles xCredentialsHintTextBlock to also check the
Server URL input control (add Server URL to the same validation path used for
ClientId/ClientSecret/TenantId), or (B) narrow the hint copy in the TextBlock
Run to explicitly list only the fields actually validated (e.g., “Please fill
Client Id, Client Secret, and Tenant Id.”) so the message matches the
implemented validation; reference xCredentialsHintTextBlock and the dialog’s
credential-validation method/handler when making the change.

[coderabbitai]

⚠️ Potential issue | 🟠 Major

Normalize device platform families before filtering.

UftPhoneViewModel.Platform comes straight from the UFT payload, and this file already treats it as non-normalized elsewhere (PopulateFilters() preselection and OkButton_Click() both use family/substring matching). Exact equality here will split one OS family into separate buckets like Android, Android TV, or versioned values and can hide valid devices when an initial platform is preselected.

🧩 Proposed fix

-            if (xOsTypeCombo?.SelectedItem is string deviceOs && !string.IsNullOrWhiteSpace(deviceOs) && !string.Equals(deviceOs, "All", StringComparison.OrdinalIgnoreCase))
-            {
-                filtered = filtered.Where(p => string.Equals(p.Platform, deviceOs, StringComparison.OrdinalIgnoreCase));
-            }
+            if (xOsTypeCombo?.SelectedItem is string deviceOs && !string.IsNullOrWhiteSpace(deviceOs) && !string.Equals(deviceOs, "All", StringComparison.OrdinalIgnoreCase))
+            {
+                filtered = filtered.Where(p => MatchesPlatformFamily(p.Platform, deviceOs));
+            }

private static bool MatchesPlatformFamily(string platform, string filter)
{
    return string.Equals(
        NormalizePlatformFamily(platform),
        NormalizePlatformFamily(filter),
        StringComparison.OrdinalIgnoreCase);
}

private static string NormalizePlatformFamily(string value)
{
    string normalized = value?.Trim().ToLowerInvariant() ?? string.Empty;

    if (normalized.Contains("ios"))
    {
        return "ios";
    }

    if (normalized.Contains("android"))
    {
        return "android";
    }

    return normalized;
}

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@Ginger/Ginger/Drivers/DriversConfigsEditPages/UFTCredentialsDialog.xaml.cs`
around lines 1049 - 1051, The filter currently uses exact equality between
xOsTypeCombo.SelectedItem and UftPhoneViewModel.Platform which splits families
like "Android TV" or versioned names; implement NormalizePlatformFamily(string)
to trim/lowercase and map any value containing "android" -> "android",
containing "ios" -> "ios", else return the normalized value, add
MatchesPlatformFamily(string platform, string filter) that compares
NormalizePlatformFamily(platform) and NormalizePlatformFamily(filter) with
OrdinalIgnoreCase, and replace the string.Equals call in the filtering block
(and any similar exact-equality platform checks) to use MatchesPlatformFamily so
devices are grouped by platform family rather than exact payload text.

[coderabbitai]

⚠️ Potential issue | 🟠 Major

Prepare the iterated window, not CurrentWindow, before printing it.

This new all-windows path still funnels through WindowToBitmap(...), but that helper calls HandlePaintWindow(CurrentWindow) and WinAPIAutomation.ShowWindow(CurrentWindow) instead of using the aw/dialog element being captured. In practice, non-current windows can come back blank or stale while the current window gets repainted repeatedly.

Suggested follow-up in WindowToBitmap(...)

public Bitmap WindowToBitmap(UIAuto.AutomationElement tempWindow)
{
    HandlePaintWindow(tempWindow);
    Thread.Sleep(200);

    int width = tempWindow.Current.BoundingRectangle.Width;
    int height = tempWindow.Current.BoundingRectangle.Height;

    if (width == 0 || height == 0)
    {
        WinAPIAutomation.ShowWindow(tempWindow);
        width = tempWindow.Current.BoundingRectangle.Width;
        height = tempWindow.Current.BoundingRectangle.Height;
    }

    Bitmap bmp = new Bitmap(width, height);
    Graphics memoryGraphics = Graphics.FromImage(bmp);
    IntPtr dc = memoryGraphics.GetHdc();
    PrintWindow(tempWindow.Current.NativeWindowHandle, dc, 0);
    memoryGraphics.ReleaseHdc(dc);
    return bmp;
}

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@Ginger/GingerCore/Actions/UIAutomation/UIAComWrapperHelper.cs` around lines
4862 - 4878, The loop over GetListOfDriverAppWindows is capturing non-current
windows but WindowToBitmap (and its helpers) still operate on CurrentWindow;
change the flow so the window element being captured (aw or dialog element
returned by GetAppDialogAsBitmap) is prepared and painted before printing: call
HandlePaintWindow(aw) (or equivalent) and WinAPIAutomation.ShowWindow(aw)
instead of operating on CurrentWindow, add a short Thread.Sleep to allow
repaint, then re-read tempWindow.Current.BoundingRectangle and if width/height
are zero call ShowWindow(aw) again before creating the Bitmap and calling
PrintWindow(tempWindow.Current.NativeWindowHandle). Ensure WindowToBitmap
accepts and uses the passed UIA element (tempWindow) throughout rather than
referencing CurrentWindow.

[coderabbitai]

⚠️ Potential issue | 🟠 Major

TakeOnlyActiveFrameOrWindowScreenShotInCaseOfFailure now changes normal screenshot behavior.

This condition runs before FullPageWithUrlAndTimestamp, so when the agent flag is true every screenshot action except OnlyActiveWindow / AllAvailableWindows is forced through AddScreenshotIntoAct(act, true). That both contradicts the setting name and makes the timestamped desktop-capture branch unreachable.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@Ginger/GingerCoreNET/Drivers/CoreDrivers/Web/Selenium/SeleniumDriver.cs`
around lines 2059 - 2065, The flag
TakeOnlyActiveFrameOrWindowScreenShotInCaseOfFailure is short-circuiting the
FullPageWithUrlAndTimestamp branch; update the conditional so the timestamped
desktop-capture branch (TakeFullPageWithDesktopScreenScreenShot) is reachable.
Either move the TakeOnlyActiveFrameOrWindowScreenShotInCaseOfFailure check below
the FullPageWithUrlAndTimestamp branch, or change its condition to only apply
when act.WindowsToCapture is One of the active-window modes (e.g.,
Act.eWindowsToCapture.OnlyActiveWindow or
Act.eWindowsToCapture.AllAvailableWindows), leaving
Act.eWindowsToCapture.FullPageWithUrlAndTimestamp to call
TakeFullPageWithDesktopScreenScreenShot(act) as intended.

[coderabbitai]

⚠️ Potential issue | 🟠 Major

Fail this action on bad input or a missing element.

This branch returns after a DEBUG log when the input is malformed, and it skips the normal null-element check before executing JS. The result is either a silent no-op or an exception escaping GenElementHandler without the usual user-facing error.

Suggested fix

                         e = LocateElement(act);
+                        if (e == null)
+                        {
+                            act.Error = "Error: Element not found - " + act.LocateBy + " " + act.LocateValue;
+                            return;
+                        }
                         char[] delimit = new char[] { '=' };
                         string insertval = act.GetInputParamCalculatedValue("Value");
                         string[] vals = insertval.Split(delimit, 2);
                         if (vals.Length != 2)
                         {
-                            Reporter.ToLog(eLogLevel.DEBUG, @"Input string should be in the format : attribute=value");
+                            act.Status = eRunStatus.Failed;
+                            act.Error = "Input string should be in the format: attribute=value";
+                            Reporter.ToLog(eLogLevel.ERROR, act.Error);
                             return;
                         }

As per coding guidelines **/*.cs: Use Reporter.ToLog(eLogLevel.ERROR, message) for logging errors.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@Ginger/GingerCoreNET/Drivers/CoreDrivers/Web/Selenium/SeleniumDriver.cs`
around lines 3689 - 3699, The branch handling attribute assignment must fail the
action and log an ERROR when input is malformed or when the target element is
missing: validate the result of act.GetInputParamCalculatedValue("Value") split
(vals) and if vals.Length != 2 call Reporter.ToLog(eLogLevel.ERROR, ...) and
return/fail the action, then call LocateElement(act) and check for null (or
handle exceptions from LocateElement) before invoking
((IJavaScriptExecutor)Driver).ExecuteScript; update the log level from DEBUG to
ERROR for bad input and ensure this code path uses the same failure/reporting
behavior as GenElementHandler for missing elements.

[coderabbitai]

⚠️ Potential issue | 🟠 Major

SVG child typing is still incomplete.

ProcessSvgChildElements() passes TypeAtt = Svg, but GetElementType() only remaps a small subset of SVG tags. Children already listed in SvgChildElements such as text, image, defs, clipPath, mask, and gradients still fall through to non-SVG enums, so filtered SVG learning will skip or misclassify part of the discovered tree.

Suggested fix

         private static eElementType GetElementType(string elementTagName, string elementTypeAtt)//elementTag = g ,typeatt = svg
         {
+            if (!string.IsNullOrEmpty(elementTypeAtt) &&
+                elementTypeAtt.Equals(nameof(eElementType.Svg), StringComparison.InvariantCultureIgnoreCase) &&
+                SvgChildElements.Contains(elementTagName))
+            {
+                return eElementType.Svg;
+            }
+
             eElementType elementType;
             elementType = elementTagName.ToUpper() switch
             {

Also applies to: 6651-6653

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@Ginger/GingerCoreNET/Drivers/CoreDrivers/Web/Selenium/SeleniumDriver.cs`
around lines 5865 - 5868, ProcessSvgChildElements is calling GetElementTypeEnum
with TypeAtt = nameof(eElementType.Svg) but GetElementTypeEnum/GetElementType
only remaps a small set of SVG tags so many SVG children (text, image, defs,
clipPath, mask and gradient nodes) fall through to non-SVG enums and get
misclassified; update the element-type mapping inside
GetElementTypeEnum/GetElementType to explicitly recognize and return
eElementType.Svg (or the appropriate SVG-specific enum) for the missing tags
(text, image, defs, clipPath, mask, linearGradient, radialGradient, etc.), and
ensure GetElementTypeEnum still respects the passed TypeAtt parameter so
ShouldLearnElement receives the correct Item2 for SVG children (apply same
changes where GetElementTypeEnum is used around the other occurrence noted).

[coderabbitai]

⚠️ Potential issue | 🟠 Major

Fix comment whitespace to avoid stylelint failure.

Line 43 uses /*Timeline*/, which violates comment-whitespace-inside.

💡 Minimal fix

-/*Timeline*/
+/* Timeline */

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	/*Timeline*/
	/* Timeline */

🧰 Tools

🪛 Stylelint (17.6.0)

[error] 43-43: Expected whitespace after "/*" (comment-whitespace-inside)

(comment-whitespace-inside)

---

[error] 43-43: Expected whitespace before "*/" (comment-whitespace-inside)

(comment-whitespace-inside)

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In
`@Ginger/GingerCoreNET/Reports/Ginger-Web-Client/assets/sass/layout/_dashboard.scss`
at line 43, The CSS comment `/*Timeline*/` violates the
comment-whitespace-inside rule; replace that exact token with `/* Timeline */`
in _dashboard.scss (update the comment text `/*Timeline*/` to include single
spaces after the opening and before the closing `/* */`) and re-run stylelint to
confirm the violation is resolved.

[coderabbitai]

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash

# Check for web client build configuration files
echo "=== Checking for web client build configuration ==="
fd -t f 'package\.json|angular\.json|webpack\.config' Ginger/GingerCoreNET/Reports/Ginger-Web-Client

# Check the .csproj to see how this file is referenced
echo -e "\n=== Checking how polyfills are referenced in .csproj ==="
rg -A 3 -B 3 'polyfills.*\.js' Ginger/GingerCoreNET/GingerCoreNET.csproj

# Check if there are other similar bundled files
echo -e "\n=== Checking for other bundled files in the same directory ==="
fd -t f '\.js$' Ginger/GingerCoreNET/Reports/Ginger-Web-Client | head -20

# Check if the old polyfills file was removed in this PR
echo -e "\n=== Checking git history for polyfills files ==="
git log --oneline --all --full-history -- '**/polyfills*.js' | head -10

Repository: Ginger-Automation/Ginger

Length of output: 2214

---

Remove the old polyfills file and document the source of this dependency.

This file is a pre-built web client asset intentionally included in source control (as confirmed by the .csproj setup with CopyToOutputDirectory=Always). However, two issues need addressing:

1. Old file still referenced: The .csproj shows the old polyfills file (polyfills.ab6619d5cdfdf12c.js) should be removed. Ensure it's deleted from both the directory and the .csproj file.

2. Source documentation: Add a comment or documentation file (e.g., README.md in Ginger/GingerCoreNET/Reports/Ginger-Web-Client/) indicating the source and version of these pre-built web assets, so future maintainers understand where these files originate and how to update them.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@Ginger/GingerCoreNET/Reports/Ginger-Web-Client/polyfills.af067c955617ac11.js`
at line 1, Remove the stale pre-built polyfills file reference by deleting
polyfills.ab6619d5cdfdf12c.js from the repository and removing its
Include/ItemGroup entry that uses CopyToOutputDirectory=Always from the project
file (the .csproj entry that references the old polyfills). Then add a short
README.md to the Ginger-Web-Client folder documenting the source/version/hash of
the shipped pre-built asset (e.g., that polyfills.af067c955617ac11.js is a
pre-built bundle, its upstream build/source and version, and instructions on how
to rebuild/update it), and commit the deletion and the documentation together so
future maintainers can find and update the polyfills asset.

[codacy-production]

Not up to standards ⛔

🔴 Issues 11 high · 12 medium · 13 minor

Alerts:
⚠ 36 issues (≤ 0 issues of at least minor severity)

Results:
36 new issues

Category	Results
BestPractice	8 medium 1 high
ErrorProne	2 medium 8 high
Security	2 high
CodeStyle	13 minor
Complexity	2 medium

View in Codacy

🟢 Metrics 1230 complexity

Metric	Results
Complexity	1230

View in Codacy

_{TIP This summary will be updated as you push new changes. Give us feedback}