Issue framagit 164 (#661)

* #164 on framagit: Improve of startup script

- See [this issue](https://framagit.org/medoc92/upmpdcli/-/issues/164)

* Framagit 164: a few improvements to the startup script

Author: GioF71

app/bin/run-upmpdcli.sh

@@ -1,10 +1,17 @@
 #!/bin/bash
 
+# avoid silent failures
+set -e
+
 ## error codes
 # 1 Generic error
 # 2 Invalid RENDERER_MODE value
 # 3 Invalid argument
 
+# show how the image was built
+build_mode=`cat /app/conf/build_mode.txt`
+echo "Image build mode: [${build_mode}]"
+
 # display upmpdcli version.
 upmpdcli -v
 
@@ -17,6 +24,20 @@ if [[ "${current_user_id}" != "0" ]]; then
     echo "Not running as root, will not be able to create users" 
 fi
 
+DEFAULT_UID=1000
+DEFAULT_GID=1000
+
+if [[ -z "${PUID}" ]]; then
+    PUID=$DEFAULT_UID
+    echo "Setting default value for PUID: ["$PUID"]"
+fi
+if [[ -z "${PGID}" ]]; then
+    PGID=$DEFAULT_GID
+    echo "Setting default value for PGID: ["$PGID"]"
+fi
+
+echo "PUID=[${PUID}] PGID=[${PGID}]"
+
 if [[ -n "${RADIO_PARADISE_DOWNLOAD_PLUGIN}" ]] ||
     [[ -n "${TIDAL_DOWNLOAD_PLUGIN}" ]] ||
     [[ -n "${SUBSONIC_DOWNLOAD_PLUGIN}" ]] ||
@@ -278,7 +299,6 @@ set_parameter $CONFIG_FILE PLG_MICRO_HTTP_HOST "$PLG_MICRO_HTTP_HOST" plgmicroht
 set_parameter $CONFIG_FILE PLG_MICRO_HTTP_PORT "$PLG_MICRO_HTTP_PORT" plgmicrohttpport
 set_parameter $CONFIG_FILE PLG_PROXY_METHOD "$PLG_PROXY_METHOD" plgproxymethod
 
-
 echo "CHECK_CONTENT_FORMAT=[${CHECK_CONTENT_FORMAT}]"
 if [[ -n "${CHECK_CONTENT_FORMAT}" ]]; then
     if [[ "${CHECK_CONTENT_FORMAT^^}" == "YES" || "${CHECK_CONTENT_FORMAT^^}" == "Y" ]]; then
@@ -641,23 +661,45 @@ if [[ "${UPRCL_ENABLE^^}" == "YES" ]]; then
     fi
 fi
 
+cache_dir_created=0
 cache_directory=/cache
 if [[ ! -w "$cache_directory" ]]; then
     echo "Cache directory [${cache_directory}] is not writable"
     cache_directory="/tmp/cache"
+    echo "Creating cache directory [$cache_directory] ..."
     mkdir -p /tmp/cache
+    cache_dir_created=1
+    echo "Cache directory [$cache_directory] created successfully"
+    if [ $current_user_id -eq 0 ]; then
+        echo "Setting ownership to [$cache_directory] ..."
+        chown -R $PUID:$PGID $cache_directory
+        echo "Setting ownership to [$cache_directory] Done"
+    else
+        echo "Not setting ownership to [$cache_directory] (uid is [$current_user_id])."
+    fi
 else
-    echo "Cache directory [${cache_directory}] is writable"
+    echo "Cache directory [$cache_directory] is writable"
 fi
 echo "cachedir = $cache_directory" >> $CONFIG_FILE
 
+log_dir_created=0
 log_directory=/log
 if [[ ! -w "$log_directory" ]]; then
-    echo "Log directory [${log_directory}] is not writable"
+    echo "Log directory [$log_directory] is not writable"
+    echo "Creating log directory [$log_directory] ..."
     mkdir -p /tmp/log
+    log_dir_created=1
     log_directory="/tmp/log"
+    echo "Log directory [$log_directory] created successfully."
+    if [ $current_user_id -eq 0 ]; then
+        echo "Setting ownership to [$log_directory] ..."
+        chown -R $PUID:$PGID $log_directory
+        echo "Setting ownership to [$log_directory] Done"
+    else
+        echo "Not setting ownership to [$log_directory] (uid is [$current_user_id])."
+    fi
 else
-    echo "Log directory [${log_directory}] is writable"
+    echo "Log directory [$log_directory] is writable"
 fi
 
 # log file support
@@ -687,7 +729,9 @@ if [[ -f $UPMPDCLI_ADDITIONAL_FILE ]]; then
     echo "Done."
 fi
 
+echo "=== <Configuration file> [$CONFIG_FILE] ==="
 cat $CONFIG_FILE
+echo "=== EOF <Configuration file> [$CONFIG_FILE] EOF ==="
 
 if [[ $current_user_id == 0 ]]; then
 
@@ -698,16 +742,6 @@ if [[ $current_user_id == 0 ]]; then
         echo "Created directory [${WEBSERVER_DOCUMENT_ROOT}]."
     fi
 
-    DEFAULT_UID=1000
-    DEFAULT_GID=1000
-
-    if [[ -z "${PUID}" ]]; then
-        PUID=$DEFAULT_UID
-    fi
-    if [[ -z "${PGID}" ]]; then
-        PGID=$DEFAULT_GID
-    fi
-
     DEFAULT_USER_NAME=upmpd-user
     DEFAULT_GROUP_NAME=upmpd-user
     DEFAULT_HOME_DIR=/home/$DEFAULT_USER_NAME
@@ -716,16 +750,6 @@ if [[ $current_user_id == 0 ]]; then
     GROUP_NAME=$DEFAULT_GROUP_NAME
     HOME_DIR=$DEFAULT_HOME_DIR
 
-    if [[ -z "${PUID}" ]]; then
-        PUID=$DEFAULT_UID;
-        echo "Setting default value for PUID: ["$PUID"]"
-    fi
-
-    if [[ -z "${PGID}" ]]; then
-        PGID=$DEFAULT_GID;
-        echo "Setting default value for PGID: ["$PGID"]"
-    fi
-
     echo "Ensuring user with uid:[$PUID] gid:[$PGID] exists ...";
 
     ### create group if it does not exist
@@ -797,6 +821,15 @@ if [[ $current_user_id == 0 ]]; then
     chown -R $USER_NAME:$GROUP_NAME /uprcl/confdir
     chown -R $USER_NAME:$GROUP_NAME /user/config
     chown -R $USER_NAME:$GROUP_NAME /log
+    if [[ $cache_dir_created -eq 1 ]]; then
+        echo "Changing ownership of /tmp/cache ..."
+        chown -R $USER_NAME:$GROUP_NAME /tmp/cache
+    fi
+    if [[ $log_dir_created -eq 1 ]]; then
+        echo "Changing ownership of /tmp/log ..."
+        chown -R $USER_NAME:$GROUP_NAME /tmp/log
+    fi
+
     echo ". done."
 
     # Correct permissions for WEBSERVER_DOCUMENT_ROOT if set
@@ -807,19 +840,19 @@ if [[ $current_user_id == 0 ]]; then
     fi
 fi
 
-build_mode=`cat /app/conf/build_mode.txt`
-
-echo "About to sleep for $STARTUP_DELAY_SEC second(s)"
-sleep $STARTUP_DELAY_SEC
-echo "Ready to start."
+if [[ -n "${STARTUP_DELAY_SEC}" ]] && [[ ${STARTUP_DELAY_SEC} != "0" ]]; then
+    echo "About to sleep for $STARTUP_DELAY_SEC second(s)"
+    sleep $STARTUP_DELAY_SEC
+    echo "Ready to start."
+fi
 
 CMD_LINE="/usr/bin/upmpdcli -c $CONFIG_FILE"
 echo "CMD_LINE=[${CMD_LINE}]"
 
 if [[ $current_user_id -eq 0 ]]; then
-    echo "USER MODE [$USER_NAME]"
+    echo "Running in USER MODE [$USER_NAME] ($PUID:$PGID) ..."
     exec su - $USER_NAME -c "$CMD_LINE"
 else
     echo "Running as current uid [$current_user_id] ..."
-    eval "exec $CMD_LINE"
+    exec $CMD_LINE
 fi

doc/change-history.md

@@ -2,6 +2,7 @@
 
 Change Date|Major Changes
 ---|---
+2026-05-03|A few improvements to the startup script (see [this issue](https://framagit.org/medoc92/upmpdcli/-/issues/164))
 2026-04-26|Submodule `master` updated to Subsonic Plugin 0.9.12
 2026-04-26|Submodule `edge` updated to Subsonic Plugin 0.9.13
 2026-04-20|Submodule `edge` updated to Subsonic Plugin 0.9.12