Skip to content

Commit 0077176

Browse files
committed
Remove IDisposable from public IDuckDBDataWriter interface
1 parent 4324846 commit 0077176

3 files changed

Lines changed: 3 additions & 3 deletions

File tree

DuckDB.NET.Data/DataChunk/Writer/IDuckDBDataWriter.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
namespace DuckDB.NET.Data.DataChunk.Writer;
22

3-
public interface IDuckDBDataWriter : IDisposable
3+
public interface IDuckDBDataWriter
44
{
55
void WriteNull(ulong rowIndex);
66
void WriteValue<T>(T value, ulong rowIndex);

DuckDB.NET.Data/DataChunk/Writer/VectorDataWriterBase.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
namespace DuckDB.NET.Data.DataChunk.Writer;
44

5-
internal unsafe class VectorDataWriterBase(IntPtr vector, void* vectorData, DuckDBType columnType) : IDuckDBDataWriter
5+
internal unsafe class VectorDataWriterBase(IntPtr vector, void* vectorData, DuckDBType columnType) : IDuckDBDataWriter, IDisposable
66
{
77
private ulong* validity;
88

DuckDB.NET.Data/DuckDBConnection.TableFunction.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -342,7 +342,7 @@ private static void TableFunction(IntPtr info, IntPtr chunk)
342342
{
343343
foreach (var writer in writers)
344344
{
345-
writer?.Dispose();
345+
(writer as IDisposable)?.Dispose();
346346
}
347347

348348
foreach (var logicalType in logicalTypes)

0 commit comments

Comments
 (0)