Skip to content

Fix decimal parameters having scale > width (#303)#304

Merged
Giorgi merged 3 commits into
Giorgi:mainfrom
Auspice-Capital:main
Nov 17, 2025
Merged

Fix decimal parameters having scale > width (#303)#304
Giorgi merged 3 commits into
Giorgi:mainfrom
Auspice-Capital:main

Conversation

@rynoV

@rynoV rynoV commented Nov 17, 2025

Copy link
Copy Markdown
Contributor

Closes #303


var result = Command.ExecuteScalar();

result.Should().BeOfType<bool>();

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add an array that holds the comparison result and validate that we get the expected result? Just to be sure that the decimal is bound correctly.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

@Giorgi Giorgi merged commit cef356d into Giorgi:main Nov 17, 2025
5 of 6 checks passed
@coveralls

coveralls commented Nov 17, 2025

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 19439070625

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.05%

Totals Coverage Status
Change from base Build 18463129159: 0.0%
Covered Lines: 2145
Relevant Lines: 2345

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants