Implemented code splitting#260
Open
akshay1027 wants to merge 1 commit intoGirl-Code-It:developfrom
Open
Conversation
Author
Author
|
@vaishali614 check this out and let me know |
vaishali614
requested changes
May 21, 2021
Member
There was a problem hiding this comment.
@akshay1027 Looks good. Few changes required:
- Delete the commented and unwanted code
- View opportunity pages don't work. Please check that.
- Instead of 'Loading...', use some spinner from here. I like the Grow Spinner. Also, try giving it some margin along y-axis so that the footer is in the bottom and spinner is in the middle of the page.
Author
|
Yea if your okay with these, I was planning to make another issue for spinner!! |
Member
Okay, but please make sure that other two changes are done in this PR. |
Member
|
@akshay1027 Any updates? |
Member
|
@akshay1027 Are you still working on this PR or should I close this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
Implemented code splitting to increases performance
Fixed #257
Please check options that are relevant to your PR.
Checklist: