chore: migrate from npm to pnpm#120
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request migrates the project's package manager from npm to pnpm, updating the pre-commit configuration, Makefile, README, package.json, Renovate configuration, and contributing guidelines. The review feedback suggests removing package-lock.json from the pre-commit exclusion list (as it should be deleted from the repository), using the more idiomatic pnpm format instead of pnpm run format in package.json, and updating the README to match this command style for consistency.
| version\.json$| | ||
| pnpm-lock\.yaml$| | ||
| package-lock\.json$ |
There was a problem hiding this comment.
Since this PR migrates the project from npm to pnpm, package-lock.json should be removed from the repository. Therefore, there is no need to add package-lock.json to the pre-commit exclusion list. We should only exclude pnpm-lock.yaml.
version\\.json$|\n pnpm-lock\\.yaml$| "dev": "node scripts/convert-notebooks.mjs && astro dev", | ||
| "start": "astro dev", | ||
| "build": "npm run format && node scripts/convert-notebooks.mjs && astro build && node scripts/generate-redirects.mjs", | ||
| "build": "pnpm run format && node scripts/convert-notebooks.mjs && astro build && node scripts/generate-redirects.mjs", |
There was a problem hiding this comment.
For consistency and idiomatic pnpm usage, we can run the format script directly using pnpm format instead of pnpm run format.
| "build": "pnpm run format && node scripts/convert-notebooks.mjs && astro build && node scripts/generate-redirects.mjs", | |
| "build": "pnpm format && node scripts/convert-notebooks.mjs && astro build && node scripts/generate-redirects.mjs", |
| - Node.js 18+ | ||
| - Python 3 + `black` (optional — only needed for `npm run format`) | ||
| - [pnpm](https://pnpm.io/) (auto-managed via the `packageManager` field in `package.json`; enable with `corepack enable`) | ||
| - Python 3 + `black` (optional, only needed for `pnpm run format`) |
There was a problem hiding this comment.
Update the reference to pnpm run format to pnpm format to match the command listed in the table below.
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
giskard-docs | 9e0b0b1 | Commit Preview URL Branch Preview URL |
May 28 2026, 03:07 PM |
1 participant
No description provided.