chore: replace any types with proper types and enforce no-explicit-any

Replace all explicit any annotations with types imported from existing
packages (vscode, sinon, child_process) or TypeScript built-ins (unknown,
inline object types, typeof console.log). Enable @typescript-eslint/no-explicit-any
as an error in ESLint to prevent regressions.

Author: GabrielCousin

src/extension.ts

@@ -9,6 +9,7 @@ import {
 import { getConfiguration } from "./lib/ggshield-configuration-utils";
 import {
   ExtensionContext,
+  OutputChannel,
   Uri,
   commands,
   languages,
@@ -39,7 +40,7 @@ import {
 
 function registerOpenViewsCommands(
   context: ExtensionContext,
-  outputChannel: any,
+  outputChannel: OutputChannel,
 ) {
   const showOutputCommand = commands.registerCommand(
     "gitguardian.showOutput",

src/gitguardian-interface/gitguardian-hover-provider.ts

@@ -65,7 +65,7 @@ function extractInfosFromMessage(message: string): {
 
 export function generateSecretName(
   currentFile: string,
-  uriDiagnostic: any,
+  uriDiagnostic: { detector: string; startLine: number },
 ): string {
   return `${uriDiagnostic.detector} - ${vscode.workspace.asRelativePath(
     currentFile,

src/lib/authentication.ts

@@ -1,6 +1,12 @@
 import { runGGShieldCommand } from "./run-ggshield";
 import { GGShieldConfiguration } from "./ggshield-configuration";
-import { commands, ExtensionContext, WebviewView, workspace } from "vscode";
+import {
+  commands,
+  ExtensionContext,
+  OutputChannel,
+  WebviewView,
+  workspace,
+} from "vscode";
 import { spawn, SpawnOptionsWithoutStdio } from "child_process";
 import * as os from "os";
 import {
@@ -104,7 +110,7 @@ export async function updateAuthenticationStatus(
 
 export async function loginGGShield(
   configuration: GGShieldConfiguration,
-  outputChannel: any,
+  outputChannel: OutputChannel,
   webviewView: WebviewView,
   context: ExtensionContext,
 ): Promise<void> {

src/test/suite/ggshield-webview/gitguardian-quota-webview.test.ts

@@ -20,7 +20,7 @@ suite("GitGuardianQuotaWebviewProvider", () => {
   setup(() => {
     mockWorkspaceState = {
       get: (_key: string) => undefined,
-      update: (_key: string, _value: any) => Promise.resolve(),
+      update: (_key: string, _value: unknown) => Promise.resolve(),
       keys: () => [],
       setKeysForSync: (_keys: readonly string[]) => {},
     };
@@ -41,7 +41,7 @@ suite("GitGuardianQuotaWebviewProvider", () => {
         onDidReceiveMessage: () => ({ dispose: () => {} }),
         cspSource: "",
         options: {} as WebviewOptions,
-        postMessage: (_message: any) => Promise.resolve(true),
+        postMessage: (_message: unknown) => Promise.resolve(true),
         asWebviewUri: (uri: Uri) => uri,
       },
       onDidChangeVisibility: () => ({ dispose: () => {} }),

src/test/suite/lib/authentication.test.ts

@@ -2,10 +2,17 @@ import { GGShieldConfiguration } from "../../../lib/ggshield-configuration";
 import * as sinon from "sinon";
 import * as runGGShield from "../../../lib/run-ggshield";
 import * as childProcess from "child_process";
+import { ChildProcessWithoutNullStreams } from "child_process";
 import * as statusBar from "../../../gitguardian-interface/gitguardian-status-bar";
 import assert from "assert";
 import { EventEmitter } from "events";
-import { commands, ExtensionContext, Memento } from "vscode";
+import {
+  commands,
+  ExtensionContext,
+  Memento,
+  OutputChannel,
+  WebviewView,
+} from "vscode";
 import {
   AuthenticationStatus,
   ConfigSource,
@@ -30,9 +37,9 @@ suite("updateAuthenticationStatus", () => {
     mockWorkspaceState = {
       get: (key: string) =>
         key === "authenticationStatus" ? authenticationStatus : undefined,
-      update: (key: string, value: any) => {
+      update: (key: string, value: unknown) => {
         if (key === "authenticationStatus") {
-          authenticationStatus = value;
+          authenticationStatus = value as AuthenticationStatus | undefined;
         }
         return Promise.resolve();
       },
@@ -169,7 +176,9 @@ suite("loginGGShield", () => {
       stdout: new EventEmitter(),
       stderr: new EventEmitter(),
     });
-    spawnMock = sinon.stub(childProcess, "spawn").returns(fakeProc as any);
+    spawnMock = sinon
+      .stub(childProcess, "spawn")
+      .returns(fakeProc as unknown as ChildProcessWithoutNullStreams);
   });
 
   teardown(function () {
@@ -196,8 +205,8 @@ suite("loginGGShield", () => {
           apiUrl: "",
           insecure: insecure,
         } as GGShieldConfiguration,
-        { appendLine: () => {} } as any,
-        { webview: { postMessage: () => {} } } as any,
+        { appendLine: () => {} } as unknown as OutputChannel,
+        { webview: { postMessage: () => {} } } as unknown as WebviewView,
         {} as ExtensionContext,
       );
 

src/test/suite/lib/ggshield-configuration-utils.test.ts

@@ -23,13 +23,13 @@ suite("getConfiguration", () => {
    * Helper class to fake different configurations of the extension
    */
   class FakeConfiguration {
-    records: Record<string, any>;
+    records: Record<string, unknown>;
 
-    constructor(records: Record<string, any>) {
+    constructor(records: Record<string, unknown>) {
       this.records = records;
     }
 
-    public get(section: string, defaultValue: any): any {
+    public get(section: string, defaultValue: unknown): unknown {
       if (this.records.hasOwnProperty(section)) {
         return this.records[section];
       }
@@ -40,13 +40,13 @@ suite("getConfiguration", () => {
   test("Vscode settings are correctly read", async () => {
     const context = {} as ExtensionContext;
     const outputChannel = window.createOutputChannel("GitGuardian");
-    context.asAbsolutePath = sinon.stub().returns("") as any;
+    context.asAbsolutePath = sinon.stub<[string], string>().returns("");
 
     getConfigurationMock.returns(
       new FakeConfiguration({
         apiUrl: "https://custom-url.com",
         insecure: true,
-      } as Record<string, any>),
+      } as Record<string, unknown>),
     );
     const configuration = await getConfiguration(context, outputChannel);
 
@@ -63,12 +63,12 @@ suite("getConfiguration", () => {
   test("insecure falls back on allowSelfSigned", async () => {
     const context = {} as ExtensionContext;
     const outputChannel = window.createOutputChannel("GitGuardian");
-    context.asAbsolutePath = sinon.stub().returns("") as any;
+    context.asAbsolutePath = sinon.stub<[string], string>().returns("");
 
     getConfigurationMock.returns(
       new FakeConfiguration({
         allowSelfSigned: true,
-      } as Record<string, any>),
+      } as Record<string, unknown>),
     );
     const configuration = await getConfiguration(context, outputChannel);
 

src/test/suite/lib/ggshield-resolver-utils.test.ts

@@ -15,7 +15,7 @@ suite("getGGShield integration tests", () => {
     window.createOutputChannel("GitGuardian");
   const platform = process.platform;
   const arch = process.arch;
-  let originalLog: (message?: any, ...optionalParams: any[]) => void;
+  let originalLog: typeof console.log;
   let output: string;
 
   setup(() => {