Avoid duplicated outputs-schema error prefix and double personality load

Surface the OutputSchemaError message directly instead of re-adding the
"invalid 'outputs' schema:" prefix it already carries, which produced
duplicated text for malformed schemas.

Load each agent personality once in the linter and reuse it for its
toolbox checks, reporting the same missing-personality error on failure.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: anticomputer

src/seclab_taskflow_agent/linting.py

@@ -140,11 +140,16 @@ def _lint_task(task: TaskDefinition, location: str, ctx: _Ctx) -> None:
 
     # Agents (personalities) and their toolboxes.
     for agent_name in task.agents or []:
-        if _check_reference(at.get_personality, agent_name, "personality", location, ctx):
+        try:
             personality = at.get_personality(agent_name)
-            if not (task.toolboxes or []):
-                for tb in personality.toolboxes or []:
-                    _check_reference(at.get_toolbox, tb, "toolbox", location, ctx)
+        except Exception as exc:  # noqa: BLE001 - loader raises several types
+            ctx.add(
+                "error", "missing-personality", f"cannot load personality {agent_name!r}: {exc}", location
+            )
+            continue
+        if not (task.toolboxes or []):
+            for tb in personality.toolboxes or []:
+                _check_reference(at.get_toolbox, tb, "toolbox", location, ctx)
 
     # Task-level toolbox overrides.
     for tb in task.toolboxes or []:

src/seclab_taskflow_agent/models.py

@@ -222,7 +222,10 @@ def _validate_outputs(self) -> TaskDefinition:
             try:
                 validate_output_schema(self.outputs)
             except OutputSchemaError as exc:
-                raise ValueError(f"invalid 'outputs' schema: {exc}") from exc
+                # OutputSchemaError already carries a fully-formed, descriptive
+                # message; surface it directly rather than re-prefixing (which
+                # would duplicate its "invalid 'outputs' schema:" prefix).
+                raise ValueError(str(exc)) from exc
         if self.over and not self.repeat_prompt:
             raise ValueError("'over' only applies to repeat_prompt tasks")
         return self

tests/test_models.py

@@ -224,6 +224,11 @@ def test_invalid_outputs_schema_rejected_at_load(self):
         with pytest.raises(ValidationError, match="invalid 'outputs' schema"):
             TaskDefinition(id="x", user_prompt="hi", outputs={"type": "not-a-json-schema-type"})
 
+    def test_invalid_outputs_schema_message_not_double_prefixed(self):
+        with pytest.raises(ValidationError) as exc_info:
+            TaskDefinition(id="x", user_prompt="hi", outputs={"type": "not-a-json-schema-type"})
+        assert str(exc_info.value).count("invalid 'outputs' schema:") == 1
+
     def test_over_requires_repeat_prompt(self):
         with pytest.raises(ValidationError, match="'over' only applies to repeat_prompt"):
             TaskDefinition(user_prompt="{{ result }}", over="outputs.x.items")