Conversation
p-
requested review from
JarLob,
Kwstubbs,
kevinbackhouse,
m-y-mo and
sylwia-budzynska
as code owners
There was a problem hiding this comment.
Pull request overview
This PR adds the LOG_DIR environment variable to all MCP server configurations, enabling them to log into a globally defined log directory. This ensures consistent log file location across all MCP servers.
- Adds
LOG_DIRenvironment variable to all stdio/streamable MCP server configurations - All affected MCP servers already use the
log_file_name()utility function which respects this environment variable
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/seclab_taskflow_agent/toolboxes/memcache.yaml | Added LOG_DIR env var to memcache MCP server configuration |
| src/seclab_taskflow_agent/toolboxes/logbook.yaml | Added LOG_DIR env var to logbook MCP server configuration |
| src/seclab_taskflow_agent/toolboxes/echo.yaml | Added LOG_DIR env var to echo MCP server configuration |
| src/seclab_taskflow_agent/toolboxes/codeql.yaml | Added LOG_DIR env var to codeql MCP server configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| GH_NO_UPDATE_NOTIFIER: "Disable" | ||
| GH_NO_EXTENSION_UPDATE_NOTIFIER: "Disable" | ||
| CODEQL_CLI: "{{ env CODEQL_CLI }}" | ||
| LOG_DIR: "{{ env LOG_DIR }}" |
There was a problem hiding this comment.
If LOG_DIR isn't defined, then it'll just use the default location in ~/.local, right?
There was a problem hiding this comment.
yes I think so, at least it falls back to this:
https://github.com/GitHubSecurityLab/seclab-taskflow-agent/blob/189004a12d76ec0eaa410e937baf0d22cfc29076/src/seclab_taskflow_agent/path_utils.py#L44C26-L44C38
this way the MCP servers will log into the "globally" defined LOG_DIR