Skip to content

Suppress linter errors via ruff configuration to re-enable CI checks#136

Merged
kevinbackhouse merged 3 commits intomainfrom
copilot/add-ruff-configuration
Jan 26, 2026
Merged

Suppress linter errors via ruff configuration to re-enable CI checks#136
kevinbackhouse merged 3 commits intomainfrom
copilot/add-ruff-configuration

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Jan 22, 2026

  • Analyze all linter errors to identify error codes
  • Add ruff configuration to pyproject.toml to suppress all current errors
  • Verify that hatch fmt --check passes with the new configuration
  • Update CI workflow to re-enable the linter check
  • Fix CI to only check linting (not formatting) using --linter flag
Original prompt

This section details on the original issue you should resolve

<issue_title>Fix linter errors</issue_title>
<issue_description>I switched off the linter because it produces 100s of error messages:

We should fix those errors (or find a way to suppress them if they're uninteresting), so that we can switch the check on.</issue_description>

<agent_instructions>Add a ruff configuration to suppress all current linter errors. I want this to be a small PR, so do not attempt to fix any of the errors, just suppress them.</agent_instructions>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

…e CI linter check

Co-authored-by: kevinbackhouse <4358136+kevinbackhouse@users.noreply.github.com>
Copilot AI changed the title [WIP] Add ruff configuration to suppress linter errors Suppress linter errors via ruff configuration to re-enable CI checks Jan 22, 2026
Copilot AI requested a review from kevinbackhouse January 22, 2026 17:08
@kevinbackhouse
Copy link
Copy Markdown
Collaborator

@copilot: the tests are failing

Co-authored-by: kevinbackhouse <4358136+kevinbackhouse@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Jan 22, 2026

@copilot: the tests are failing

Fixed in c2b6dca. The issue was that hatch fmt --check runs both linter and formatter checks. The linter now passes but files need reformatting. Changed CI to use --linter flag to only check linting, not formatting.

@kevinbackhouse kevinbackhouse marked this pull request as ready for review January 22, 2026 22:10
Copilot AI review requested due to automatic review settings January 22, 2026 22:10
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses issue #83 by configuring ruff to suppress all existing linter errors and re-enabling the linter check in CI. Rather than fixing hundreds of linter errors, this establishes a baseline by ignoring current violations, allowing the linter to catch new issues going forward.

Changes:

  • Added comprehensive ruff configuration to pyproject.toml with 81 suppressed error codes
  • Re-enabled linter check in CI workflow using hatch fmt --linter --check

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
pyproject.toml Adds ruff configuration section with target-version py310 and comprehensive ignore list of 81 error codes covering various categories (unused imports, naming conventions, type annotations, etc.)
.github/workflows/ci.yml Replaces commented-out linter check with active hatch fmt --linter --check command to run linting in CI

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@kevinbackhouse kevinbackhouse merged commit f9d808c into main Jan 26, 2026
15 checks passed
@kevinbackhouse kevinbackhouse deleted the copilot/add-ruff-configuration branch January 26, 2026 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix linter errors

4 participants