Use globally unique filekeys for referencing other yaml files#16
Merged
kevinbackhouse merged 5 commits intoOct 21, 2025
Merged
Conversation
7b51bb8 to
389d3c3
Compare
Contributor
|
Could you also change the |
389d3c3 to
0e4502c
Compare
Collaborator
Author
|
This is now updated to use "filekeys" for cross-referencing. |
Contributor
|
Can we drop the |
p-
reviewed
Oct 21, 2025
Co-authored-by: Peter Stöckli <p-@github.com>
585f3c1 to
104a974
Compare
Collaborator
Author
|
smoke test |
p-
approved these changes
Oct 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main change is in
yaml_parser.pywhere I've removed the optionalrecurseanddir_namespaceparameters. It now always recurses and always creates a namespaced name. Also, the name is no longer defined by the filename, but instead by the "filekey" that is defined in the yaml, like this:This has the benefit that a yaml file can moved to a different directory without breaking any cross-references. It also means that we can gather yaml files from a variety of sources, dump them all in one directory tree, and easily start using them.