Fix TRY003: encapsulate exception messages in custom exception classes#195
Closed
Fix TRY003: encapsulate exception messages in custom exception classes#195
Conversation
Open
Agent-Logs-Url: https://github.com/GitHubSecurityLab/seclab-taskflow-agent/sessions/a6caebd1-4fb9-47b1-9eea-ca8124874591 Co-authored-by: kevinbackhouse <4358136+kevinbackhouse@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix linter error TRY003 and remove from suppression list
Fix TRY003: encapsulate exception messages in custom exception classes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TRY003 flags long exception messages constructed at the
raisesite rather than inside the exception class. This removes the suppression and fixes all 58 violations across the codebase.Approach
Each unique error message is moved into a dedicated exception class
__init__, so call sites pass typed context instead of formatted strings:New files
exceptions.py— 25+ custom exception classes for the main package, organized by domain (API/token, MCP transport, runner, session, shell, template)mcp_servers/codeql/exceptions.py— CodeQL-specific exceptions (NoActiveDatabaseError,LegacyServerNotSupportedError,UnsupportedOutputFormatError, etc.)Updated files
available_tools.py— addsBadToolNameError/FileTypeExceptionsubclasses (InvalidToolFormatError,ToolDirNotFoundError,FiletypeMismatchError, etc.) so existingexcept BadToolNameErrorhandlers are unaffectedpyproject.tomlTRY003from the globalignorelistper-file-ignoresfor the vendoredjsonrpyc/__init__.pyto preserve that third-party code unchangedWarning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
unsupported.example.com/usr/bin/python python -m pytest tests/ -v(dns block)/usr/bin/python python -m pytest tests/ -q get --global git committer.email(dns block)If you need me to access, download, or install something from one of these locations, you can either: