Fix A002: rename id parameter to request_id in Spec class#199
Draft
Fix A002: rename id parameter to request_id in Spec class#199
id parameter to request_id in Spec class#199Conversation
Open
Agent-Logs-Url: https://github.com/GitHubSecurityLab/seclab-taskflow-agent/sessions/c5f089f2-6b83-41f3-97c7-a4d4417ef555 Co-authored-by: kevinbackhouse <4358136+kevinbackhouse@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix linter error A002 and update suppression list
Fix A002: rename Apr 2, 2026
id parameter to request_id in Spec class
kevinbackhouse
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ruff rule A002 flags function arguments that shadow Python builtins. The
Specclass injsonrpyc/__init__.pyusedidas a parameter name in four methods, shadowing the built-inid().Changes
jsonrpyc/__init__.py: Renamedid→request_idinSpec.check_id,Spec.request,Spec.response, andSpec.error, including all internal usages, the one keyword-argument call site (Spec.request(method, id=id, ...)→Spec.request(method, request_id=id, ...)), and docstrings.pyproject.toml: RemovedA002from the ruffignorelist.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
unsupported.example.com/usr/bin/python python -m pytest tests/ -x -q(dns block)If you need me to access, download, or install something from one of these locations, you can either: