Skip to content

Fix FBT002: make boolean params keyword-only across codebase#209

Draft
Copilot wants to merge 2 commits intomainfrom
copilot/fbt002-fix-linter-error-again
Draft

Fix FBT002: make boolean params keyword-only across codebase#209
Copilot wants to merge 2 commits intomainfrom
copilot/fbt002-fix-linter-error-again

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 8, 2026

Resolve all 22 FBT002 (boolean default positional argument) lint violations and remove the rule from the Ruff suppression list.

Changes

  • Function signatures: Add * separator before boolean parameters with defaults, making them keyword-only
  • Call site fix: Update one caller in runner.py that passed headless positionally to build_mcp_servers()
  • pyproject.toml: Remove FBT002 from [tool.ruff.lint] ignore

Affected modules: agent.py, cli.py, mcp_lifecycle.py, runner.py, render_utils.py, template_utils.py, codeql/client.py, codeql/jsonrpyc/__init__.py, scripts/migrate_to_jinja2.py

# Before
def build_mcp_servers(available_tools, toolboxes, blocked_tools=None, headless=False): ...

# After
def build_mcp_servers(available_tools, toolboxes, blocked_tools=None, *, headless=False): ...

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • unsupported.example.com
    • Triggering command: /usr/bin/python python -m pytest tests/ -x -q (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI requested review from Copilot and removed request for Copilot April 8, 2026 12:51
Copilot AI linked an issue Apr 8, 2026 that may be closed by this pull request
Add `*` separator before boolean parameters with default values in
function signatures across the codebase, making them keyword-only.
Update the one call site in runner.py that passed `headless`
positionally. Remove FBT002 from the Ruff suppression list in
pyproject.toml.

Agent-Logs-Url: https://github.com/GitHubSecurityLab/seclab-taskflow-agent/sessions/c62a0336-fc2b-4a89-8281-bc7ce587d043

Co-authored-by: kevinbackhouse <4358136+kevinbackhouse@users.noreply.github.com>
Copilot AI requested review from Copilot and removed request for Copilot April 8, 2026 12:57
Copilot AI changed the title [WIP] Fix linter error FBT002 and remove from suppression list Fix FBT002: make boolean params keyword-only across codebase Apr 8, 2026
Copilot AI requested a review from kevinbackhouse April 8, 2026 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FBT002

2 participants