Fix FBT002: make boolean params keyword-only across codebase#209
Draft
Fix FBT002: make boolean params keyword-only across codebase#209
Conversation
Open
Add `*` separator before boolean parameters with default values in function signatures across the codebase, making them keyword-only. Update the one call site in runner.py that passed `headless` positionally. Remove FBT002 from the Ruff suppression list in pyproject.toml. Agent-Logs-Url: https://github.com/GitHubSecurityLab/seclab-taskflow-agent/sessions/c62a0336-fc2b-4a89-8281-bc7ce587d043 Co-authored-by: kevinbackhouse <4358136+kevinbackhouse@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix linter error FBT002 and remove from suppression list
Fix FBT002: make boolean params keyword-only across codebase
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve all 22 FBT002 (boolean default positional argument) lint violations and remove the rule from the Ruff suppression list.
Changes
*separator before boolean parameters with defaults, making them keyword-onlyrunner.pythat passedheadlesspositionally tobuild_mcp_servers()pyproject.toml: RemoveFBT002from[tool.ruff.lint] ignoreAffected modules:
agent.py,cli.py,mcp_lifecycle.py,runner.py,render_utils.py,template_utils.py,codeql/client.py,codeql/jsonrpyc/__init__.py,scripts/migrate_to_jinja2.pyWarning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
unsupported.example.com/usr/bin/python python -m pytest tests/ -x -q(dns block)If you need me to access, download, or install something from one of these locations, you can either: