Split workflow to reduce the available permissions during the build step#246
Open
kevinbackhouse wants to merge 1 commit into
Open
Split workflow to reduce the available permissions during the build step#246kevinbackhouse wants to merge 1 commit into
kevinbackhouse wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens the PyPI publishing GitHub Actions workflow by splitting the build and publish phases into separate jobs so that elevated permissions (notably OIDC id-token: write) are only available during the publish phase, aligning with the trusted publisher security model (Fixes #228).
Changes:
- Split the workflow into a low-permission
buildjob and a higher-permissionpublishjob. - Upload built distributions as artifacts from the build job and download them in the publish job.
- Move provenance attestation to the publish job alongside publishing.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/publish-to-pypi.yaml | Splits build vs publish into separate jobs to minimize permissions during build, using artifacts to pass dists to the publishing job. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 1
| path: ./dist/ | ||
|
|
||
| - name: Attest build provenance | ||
| uses: actions/attest@v4.1.0 # immutable release |
kevinbackhouse
requested review from
JarLob,
Kwstubbs,
anticomputer,
p- and
sylwia-budzynska
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #228
This PR makes the same changes as #243 and #245, except on the PyPI workflow.