Skip to content

Remove obsolete Ruff A004 suppression from lint config#250

Open
Copilot wants to merge 2 commits into
mainfrom
copilot/fix-linter-error-a004-again
Open

Remove obsolete Ruff A004 suppression from lint config#250
Copilot wants to merge 2 commits into
mainfrom
copilot/fix-linter-error-a004-again

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Jun 1, 2026

This issue requested fixing A004 and removing its suppression from pyproject.toml. The codebase no longer needs the suppression, so the config is now aligned with actual lint state.

  • Lint configuration cleanup

    • Removed A004 (import shadows built-in) from the global Ruff ignore list in pyproject.toml.
    • No source code changes were required because there are no active A004 violations.
  • Resulting config diff

    [tool.ruff.lint]
    ignore = [
      "A001",     # Variable shadows built-in
      "A002",     # Argument shadows built-in
      # "A004",   # Import shadows built-in  <-- removed
      "FBT001",
      ...
    ]

Copilot AI review requested due to automatic review settings June 1, 2026 13:34
Copilot AI review requested due to automatic review settings June 1, 2026 13:34
Copilot AI linked an issue Jun 1, 2026 that may be closed by this pull request
Copilot AI requested review from Copilot and removed request for Copilot June 1, 2026 13:41
Copilot AI changed the title [WIP] Fix linter error A004 and remove it from suppression list Remove obsolete Ruff A004 suppression from lint config Jun 1, 2026
Copilot AI requested a review from kevinbackhouse June 1, 2026 13:42
@kevinbackhouse kevinbackhouse marked this pull request as ready for review June 1, 2026 15:01
Copilot AI review requested due to automatic review settings June 1, 2026 15:01
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR cleans up the repository’s Ruff lint configuration by removing an obsolete global suppression for A004 (“import shadows built-in”) from pyproject.toml, aligning the config with the current lint state.

Changes:

  • Removed A004 from [tool.ruff.lint].ignore in pyproject.toml.
Show a summary per file
File Description
pyproject.toml Removes the now-unneeded A004 ignore entry from the Ruff lint ignore list.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 1/1 changed files
  • Comments generated: 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A004

4 participants