Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/seclab_taskflow_agent/mcp_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -238,13 +238,13 @@ def mcp_client_params(

case "sse":
headers = _resolve_headers(sp.headers, sp.optional_headers)
server_params["url"] = sp.url
server_params["url"] = swap_env(sp.url) if sp.url is not None else None
server_params["headers"] = headers
server_params["timeout"] = sp.timeout

case "streamable":
headers = _resolve_headers(sp.headers, sp.optional_headers)
server_params["url"] = sp.url
server_params["url"] = swap_env(sp.url) if sp.url is not None else None
server_params["headers"] = headers
server_params["timeout"] = sp.timeout

Expand Down
31 changes: 31 additions & 0 deletions tests/test_mcp_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -196,3 +196,34 @@ def test_env_names_returns_sorted_names_or_none():
assert _env_names({"B_VAR": "x", "A_VAR": "{{ env('A') }}"}) == ["A_VAR", "B_VAR"]
assert _env_names({}) == []
assert _env_names(None) is None


@pytest.mark.parametrize("kind", ["streamable", "sse"])
def test_mcp_client_params_resolves_remote_url_env(monkeypatch, kind):
# A remote toolbox sources its endpoint from the environment. The url must
# be env-templated the same way stdio args/env and headers already are, so
# `url: "{{ env('CONTAINER_SHELL_URL') }}"` reaches the client resolved.
monkeypatch.setenv("CONTAINER_SHELL_URL", "http://host.docker.internal:8765/mcp/")
server_params = SimpleNamespace(
kind=kind,
reconnecting=False,
url="{{ env('CONTAINER_SHELL_URL') }}",
headers=None,
optional_headers=None,
timeout=None,
command=None,
env=None,
args=None,
)
toolbox = SimpleNamespace(
server_params=server_params,
confirm=["container_shell_exec"],
server_prompt=None,
client_session_timeout=None,
)
available_tools = MagicMock()
available_tools.get_toolbox.return_value = toolbox

params = mcp_client_params(available_tools, ["pkg.remote"])

assert params["pkg.remote"][0]["url"] == "http://host.docker.internal:8765/mcp/"