Make sure that the logs directory exists#62
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates log directory handling to dynamically create the logs/ directory at runtime instead of requiring it to exist in the repository. The code now uses pathlib.Path to programmatically create the directory before attempting to write log files.
- Replaced hardcoded string path with
pathlib.Pathobject for log directory creation - Added automatic directory creation with
mkdir(parents=True, exist_ok=True) - Updated
.gitignoreto exclude the entirelogs/directory instead of just*.logfiles - Removed the placeholder
logs/ABOUTfile since the directory is now created programmatically
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/seclab_taskflow_agent/__main__.py |
Added dynamic log directory creation using pathlib and updated log file path construction |
logs/ABOUT |
Removed placeholder file as logs directory is now created programmatically |
.gitignore |
Updated to ignore entire logs directory instead of just *.log files |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JarLob
approved these changes
Nov 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think the
ABOUTfile in the logs directory was a hack to make sure that the directory exists. It's better to usemkdirso that it also works if the tool is run from a different directory.