Skip to content

Add LOG_DIR variable to README #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
p- merged 2 commits into from
Dec 11, 2025
Merged

Add LOG_DIR variable to README #16

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7da7b27
Add LOG_DIR variable to README
p- Dec 11, 2025
8b91028
Update README.md
p- Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,10 @@ This repository contains example taskflows to use with the [SecLab Taskflow Agen
MEMCACHE_STATE_DIR=/app/data
CODEQL_DBS_BASE_PATH=/app/data
DATA_DIR=/app/data
LOG_DIR=/app/logs
```

Comment on lines +9 to 11
Copy link

Copilot AI Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The LOG_DIR environment variable is added to the configuration example but is not actually used anywhere in the codebase. All logging configurations use the log_file_name function from seclab_taskflow_agent.path_utils, which likely manages its own log directory path. Either this variable should be integrated into the actual logging configuration, or it should be removed from the documentation if it's not currently supported.

Suggested change
LOG_DIR=/app/logs
```

Copilot uses AI. Check for mistakes.
The `MEMCACHE_STATE_DIR` is needed to persist some intermediate data in the memcache, `DATA_DIR` is needed for various mcp server to store intermediate results. These can be set in a `.env` file in the `src` directory.
The `MEMCACHE_STATE_DIR` is needed to persist some intermediate data in the memcache, `DATA_DIR` is needed for various mcp servers to store intermediate results, and `LOG_DIR` is used to store log files generated by the servers. These can be set in a `.env` file in the `src` directory.

The repo provides a script [`run_seclab_agent.sh`](https://github.com/GitHubSecurityLab/seclab-taskflows/blob/main/src/run_seclab_agent.sh) to run a docker container of the `seclab-taskflow-agent` as outlined [here](https://github.com/GitHubSecurityLab/seclab-taskflow-agent/tree/main?tab=readme-ov-file#deploying-from-docker). Note that this script needs to be run from the `src` directory.

Expand Down