Revert run_seclab_agent.sh back to its previous behavior#41
Merged
kevinbackhouse merged 2 commits intoGitHubSecurityLab:mainfrom Feb 6, 2026
Merged
Revert run_seclab_agent.sh back to its previous behavior#41kevinbackhouse merged 2 commits intoGitHubSecurityLab:mainfrom
kevinbackhouse merged 2 commits intoGitHubSecurityLab:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts the behavior of run_seclab_agent.sh to its pre-PR#34 state by creating a new run_in_docker.sh script that contains the general-purpose Docker runner functionality from PR#34, while making run_seclab_agent.sh a simple wrapper that specifically runs the seclab taskflow agent.
Changes:
- Created new
run_in_docker.shscript that runs arbitrary commands in a Docker container with proper environment setup - Modified
run_seclab_agent.shto be a lightweight wrapper that callsrun_in_docker.shwith thepython -m seclab_taskflow_agentcommand hardcoded
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| scripts/run_in_docker.sh | New file containing the Docker runner functionality from the previous run_seclab_agent.sh (from PR#34), which sets up directories, mounts volumes, and runs commands in a Docker container |
| scripts/run_seclab_agent.sh | Simplified to be a wrapper that determines its own directory and delegates to run_in_docker.sh with the seclab agent command hardcoded |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kevinbackhouse
force-pushed
the
run-in-docker
branch
from
627ff65 to
752a189
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kevinbackhouse
requested review from
JarLob,
m-y-mo,
p- and
sylwia-budzynska
as code owners
p-
approved these changes
Feb 6, 2026
kiandadban
pushed a commit
to kiandadban/seclab-taskflows
that referenced
this pull request
May 4, 2026
…cker Revert run_seclab_agent.sh back to its previous behavior
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #34, I changed the behavior of
run_seclab_agent.sh. This PR changes the name of the new script torun_in_docker.shand creates a new script namedrun_seclab_agent.sh, which behaves the same as the old version from before #34.