fix and standardize tests

Author: nbransby

src/test/kotlin/AuthTest.kt

@@ -5,9 +5,9 @@ import com.google.firebase.FirebasePlatform
 import com.google.firebase.initialize
 import org.junit.Test
 
-class AppTest : FirebaseTest() {
+class FirebaseAppTest : FirebaseTest() {
     @Test
-    fun testInitialize() {
+    fun `initialize firebase`() {
         FirebasePlatform.initializeFirebasePlatform(
             object : FirebasePlatform() {
                 val storage = mutableMapOf<String, String>()
@@ -36,6 +36,6 @@ class AppTest : FirebaseTest() {
                 .setStorageBucket("fir-java-sdk.appspot.com")
                 .setGcmSenderId("341458593155")
                 .build()
-        val app = Firebase.initialize(Application(), options)
+        Firebase.initialize(Application(), options)
     }
 }

src/test/kotlin/AppTest.kt src/test/kotlin/FirebaseAppTest.ktsrc/test/kotlin/AppTest.kt renamed to src/test/kotlin/FirebaseAppTest.kt

@@ -1,21 +1,41 @@
-
 import android.net.Uri
-import com.google.firebase.auth.FirebaseUser
+import com.google.firebase.auth.FirebaseAuth
+import com.google.firebase.auth.FirebaseAuthInvalidUserException
+import kotlinx.coroutines.runBlocking
 import kotlinx.coroutines.tasks.await
 import kotlinx.coroutines.test.runTest
 import org.junit.Assert.assertEquals
 import org.junit.Assert.assertNotEquals
+import org.junit.Assert.assertThrows
+import org.junit.Before
 import org.junit.Test
 import java.util.UUID
 
-internal class FirebaseAuthTest : FirebaseTest() {
+class FirebaseAuthTest : FirebaseTest() {
+    private val email = "email${UUID.randomUUID()}@example.com"
+    private val auth by lazy { FirebaseAuth.getInstance(app) }
+
+    @Before
+    fun initialize() {
+        auth.apply {
+            useEmulator("localhost", 9099)
+        }
+    }
+
     @Test
-    fun testCreateUserWithEmailAndPassword() =
+    fun `should authenticate via anonymous auth`() =
+        runTest {
+            auth.signInAnonymously().await()
+            assertEquals(null, auth.currentUser!!.email)
+            assertEquals(true, auth.currentUser!!.isAnonymous)
+        }
+
+    @Test
+    fun `should create user via email and password`() =
         runTest {
-            val email = "test+${UUID.randomUUID()}@test.com"
             val createResult = auth.createUserWithEmailAndPassword(email, "test123").await()
             assertNotEquals(null, createResult.user?.uid)
-            // assertEquals(null, createResult.user?.displayName)
+            assertEquals(null, createResult.user?.displayName)
             // assertEquals(null, createResult.user?.phoneNumber)
             assertEquals(false, createResult.user?.isAnonymous)
             assertEquals(email, createResult.user?.email)
@@ -26,10 +46,38 @@ internal class FirebaseAuthTest : FirebaseTest() {
         }
 
     @Test
-    fun testUpdateProfile() =
+    fun `should authenticate via email and password`() =
+        runTest {
+            auth.createUserWithEmailAndPassword(email, "test123").await()
+
+            auth.signInWithEmailAndPassword(email, "test123").await()
+
+            assertEquals(false, auth.currentUser?.isAnonymous)
+        }
+
+    /*@Test
+    fun `should authenticate via custom token`() =
+        runTest {
+            val user = auth.createUserWithEmailAndPassword(email, "test123").await()
+            auth
+                .signInWithCustomToken(
+                    user.user
+                        .getIdToken(false)
+                        .await()
+                        .token ?: "",
+                ).await()
+
+            assertEquals(false, auth.currentUser?.isAnonymous)
+        }*/
+
+    @Test
+    fun `should update displayName and photoUrl`() =
         runTest {
-            val user = createUser()
-            user
+            auth
+                .createUserWithEmailAndPassword(email, "test123")
+                .await()
+                .user
+            auth.currentUser
                 ?.updateProfile(
                     com.google.firebase.auth.UserProfileChangeRequest
                         .Builder()
@@ -42,16 +90,25 @@ internal class FirebaseAuthTest : FirebaseTest() {
         }
 
     @Test
-    fun testSignInAnonymously() =
+    fun `should sign in anonymously`() =
         runTest {
             val signInResult = auth.signInAnonymously().await()
             assertNotEquals("", signInResult.user!!.email)
             assertEquals(true, signInResult.user?.isAnonymous)
         }
 
-    private suspend fun createUser(email: String = "test+${UUID.randomUUID()}@test.com"): FirebaseUser? =
-        auth
-            .createUserWithEmailAndPassword(email, "test123")
-            .await()
-            .user
+    @Test
+    fun `should throw exception on invalid password`() =
+        runTest {
+            auth.createUserWithEmailAndPassword(email, "test123").await()
+
+            val exception =
+                assertThrows(FirebaseAuthInvalidUserException::class.java) {
+                    runBlocking {
+                        auth.signInWithEmailAndPassword(email, "wrongpassword").await()
+                    }
+                }
+
+            assertEquals("INVALID_PASSWORD", exception.errorCode)
+        }
 }

src/test/kotlin/FirebaseAuthTest.kt

@@ -5,10 +5,10 @@ import kotlinx.coroutines.test.runTest
 import org.junit.Assert.assertEquals
 import org.junit.Test
 
-class FirestoreTest : FirebaseTest() {
+class FirebaseFirestoreTest : FirebaseTest() {
 
     @Test
-    fun testFirestore(): Unit = runTest {
+    fun `set and get a document`(): Unit = runTest {
         val firestore = Firebase.firestore(app)
         firestore.disableNetwork().await()
 

src/test/kotlin/FirestoreTest.kt src/test/kotlin/FirebaseFirestoreTest.ktsrc/test/kotlin/FirestoreTest.kt renamed to src/test/kotlin/FirebaseFirestoreTest.kt

@@ -5,10 +5,10 @@ import com.google.firebase.storage.storage
 import org.junit.Assert
 import org.junit.Test
 
-class FirestoreStorageTest : FirebaseTest() {
+class FirebaseStorageTest : FirebaseTest() {
 
     @Test
-    fun test_parsing_storage_uri() {
+    fun `parsing storage uri`() {
         val input = "gs://edifikana-stage.appspot.com"
 
         val normalized = Slashes.normalizeSlashes(input.substring(5))
@@ -19,19 +19,19 @@ class FirestoreStorageTest : FirebaseTest() {
     }
 
     @Test
-    fun test_loading_default_storage_client() {
+    fun `loading default storage client`() {
         Firebase.storage(app)
     }
 
     @Test
-    fun test_getting_root_reference() {
+    fun `getting root reference`() {
         val storage = Firebase.storage(app)
         val reference = storage.reference
         Assert.assertNotNull(reference)
     }
 
     @Test
-    fun test_getting_child_reference() {
+    fun `getting child reference`() {
         val storage = Firebase.storage(app)
         val reference = storage.reference
         val downloadRef = reference.child("mountains.jpg")

src/test/kotlin/FirestoreStorageTest.kt src/test/kotlin/FirebaseStorageTest.ktsrc/test/kotlin/FirestoreStorageTest.kt renamed to src/test/kotlin/FirebaseStorageTest.kt

@@ -3,16 +3,14 @@ import com.google.firebase.Firebase
 import com.google.firebase.FirebaseApp
 import com.google.firebase.FirebaseOptions
 import com.google.firebase.FirebasePlatform
-import com.google.firebase.auth.FirebaseAuth
 import com.google.firebase.initialize
 import org.junit.After
 import org.junit.Before
 import java.io.File
 
 abstract class FirebaseTest {
-    protected lateinit var auth: FirebaseAuth
 
-    protected val app: FirebaseApp get() {
+    protected val app: FirebaseApp by lazy {
         val options =
             FirebaseOptions
                 .Builder()
@@ -24,7 +22,7 @@ abstract class FirebaseTest {
                 .setGcmSenderId("341458593155")
                 .build()
 
-        return Firebase.initialize(Application(), options)
+        Firebase.initialize(Application(), options)
     }
 
     @Before
@@ -49,25 +47,10 @@ abstract class FirebaseTest {
                 override fun getDatabasePath(name: String) = File("./build/$name")
             }
         )
-        val options =
-            FirebaseOptions
-                .Builder()
-                .setProjectId("fir-java-sdk")
-                .setApplicationId("1:341458593155:web:bf8e1aa37efe01f32d42b6")
-                .setApiKey("AIzaSyCvVHjTJHyeStnzIE7J9LLtHqWk6reGM08")
-                .setDatabaseUrl("https://fir-java-sdk-default-rtdb.firebaseio.com")
-                .setStorageBucket("fir-java-sdk.appspot.com")
-                .setGcmSenderId("341458593155")
-                .build()
-
-        val firebaseApp = Firebase.initialize(Application(), options)
-        auth = FirebaseAuth.getInstance(app = firebaseApp)
-
-        FirebaseApp.clearInstancesForTest()
     }
 
     @After
     fun clear() {
-        auth.currentUser?.delete()
+        FirebaseApp.clearInstancesForTest()
     }
 }