Optionally set the dynamic link domain#813
Open
robholmes wants to merge 1 commit intoGitLiveApp:masterfrom
Open
Optionally set the dynamic link domain#813robholmes wants to merge 1 commit intoGitLiveApp:masterfrom
robholmes wants to merge 1 commit intoGitLiveApp:masterfrom
Conversation
Dynamic link domains are now deprecated and if the firebase iOS SDK version is 12+ then the function has been removed. Causing the following crash, even though the `dynamicLinkDomain` is `null`. This at least supports not calling the removed function if the value is null. ``` Fatal Exception: NSInvalidArgumentException -[FIRActionCodeSettings setDynamicLinkDomain:]: unrecognized selector sent to instance ```
Author
|
This should also fix: #786 |
marcorighini
approved these changes
Apr 17, 2026
|
@Reedyuk do you think this can be merged and a new version be released? Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dynamic link domains are now deprecated and if the firebase iOS SDK version is 12+ then the function has been removed. Causing the following crash, even though the
dynamicLinkDomainisnull. This at least supports not calling the removed function if the value is null.Why?
Due to a bug in iOS 26.4 and the Firebase iOS SDK (detailed here: firebase/firebase-ios-sdk#16033), a fix was applied in 12.12.0 and above of the Firebase iOS SDK.
So to fix the crash, we need to update the Firebase iOS SDK version to 12.12.0 and above in xcode.
But doing this then leads to the removed
setDynamicLinkDomaincrash above.