Add Query.get() to Realtime Database#818
Open
pmodernme wants to merge 3 commits intoGitLiveApp:masterfrom
Open
Add Query.get() to Realtime Database#818pmodernme wants to merge 3 commits intoGitLiveApp:masterfrom
pmodernme wants to merge 3 commits intoGitLiveApp:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
Query.get()across Android, Apple, and JS. Previous implementations usedQuery.valueEvents.first()to fetch a single value, but that returns either local or remote data depending on whether persistence is enabled.get()always fetches from the server and falls back to the locally-cached value (or null) if offline, giving consistent behavior regardless of persistence settings.Cancellation is supported. If the coroutine is cancelled while waiting, the underlying request is cancelled as well.
Test plan
Query.get()returns remote data on Android, iOS, and JS