Skip to content

Commit cd1cf40

Browse files
committed
refactor(arguments): Use extension method for boolean string parsing
1 parent 37a4564 commit cd1cf40

1 file changed

Lines changed: 2 additions & 5 deletions

File tree

src/GitVersion.App/ArgumentParser.cs

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,7 @@ private void MapParsedValues(Arguments arguments, ParseResult parseResult, Comma
177177
arguments.UpdateAssemblyInfo = true;
178178
if (values != null)
179179
{
180-
foreach (var file in values.Where(f => !IsBooleanTrue(f)))
180+
foreach (var file in values.Where(f => !f.IsTrue()))
181181
{
182182
arguments.UpdateAssemblyInfoFileName.Add(file);
183183
}
@@ -195,7 +195,7 @@ private void MapParsedValues(Arguments arguments, ParseResult parseResult, Comma
195195
arguments.UpdateProjectFiles = true;
196196
if (parseResult.GetValue(options.UpdateProjectFiles) is { } projectFiles)
197197
{
198-
foreach (var file in projectFiles.Where(f => !IsBooleanTrue(f)))
198+
foreach (var file in projectFiles.Where(f => !f.IsTrue()))
199199
{
200200
arguments.UpdateAssemblyInfoFileName.Add(file);
201201
}
@@ -276,9 +276,6 @@ private void MapParsedValues(Arguments arguments, ParseResult parseResult, Comma
276276
}
277277
}
278278

279-
private static bool IsBooleanTrue(string value) =>
280-
value.Equals("true", StringComparison.OrdinalIgnoreCase) || value.Equals("1", StringComparison.Ordinal);
281-
282279
private static (RootCommand Root, CommandOptions Options) BuildCommand()
283280
{
284281
var path = new Argument<string?>("path")

0 commit comments

Comments
 (0)